Comments (5)
That sounds great @skosch - Thanks!
from mailman.
Done; along with an updated README and some other small fixes.
Note that the meanings of attach
and inline
have changed to correspond to their actual semantics (i.e. attachment disposition). You can now use file paths or URLs for either.
I'm trying to follow the common Elixir style guides as best as I can with the code I write, though I haven't gone through to fix everything (I know spaces in braces are a contentious issue, but I figure following convention doesn't hurt)
I would appreciate if you guys could take a look at the changes. Once we're all happy with it we can merge it into master. (Oh, and then transfer the project to the organization :))
from mailman.
@skosch This is mighty! :) Looks awesome - Thanks so much for the effort. We can merge it into the master, update the version number and publish to hex. I'll let you do the first part ion case there's anything you might want to add to the solution. Once we have that in master I'll go ahead and publish for other folks to use.
Thanks again!
from mailman.
Cool, thank you @kamilc, I've merged into master. I'm sure there's potential for improvement here and there; hopefully people will just open issues if there are problems.
Go ahead with the release then (although actually maybe @Ch4s3 wants to have a look at the changes too, sorry I forgot about you – speak now or forever hold your peace :)
from mailman.
I've used it for a few thousand emails with inline images and have had no problems, so I'm closing this.
from mailman.
Related Issues (20)
- Attatchment file name incorrect
- Moving to organization based repo HOT 6
- Let's make mailman more attractive
- CI testing seems to be broken?
- Code style cleanup (credo + dialyxir)
- Add CONTRIBUTING.md HOT 2
- The readme claims wrong version is installable through hex HOT 8
- All links for Contributors of README is wrong HOT 1
- Certain circumstances crash from Mailman.Email.parse!
- Compatibility error with Elixir 1.7 when sending mail HOT 7
- `Mailmain.Email.parse!` usage
- Conflict with Erlang/OTP-22 socket module
- Deprecated Httpotion HOT 2
- ** (FunctionClauseError) no function clause matching in Mailman.Render.normalize_addresses/1 HOT 1
- Argument error with elixir 1.11.4 HOT 2
- %Mailman.deliver/2 eats my attachments HOT 3
- How to add dep to mix.exs HOT 2
- How can I change the return path before deliver the mail?
- Weird LICENSE symlink issue with hex.pm mailman package
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mailman.