Comments (4)
This was interesting to debug! This is the Git Blame for the cause of the issue: Spigot Messenger.java.
Here's my vague history of custom packets:
- Jan. 2012: Dinnerbone creates the API blog post
- This is around the 1.1/1.2 update?
- The max length is 16 chars.
- Sometime before Aug. 2017: The length is increased
- Sometime before the 1.11 update
- New length is 20 chars.
- During the 1.11 update: The length is increased
- New length is 32 chars?
- During the 1.13 update: The length cap is removed
- According to this protocol wiki change (link) by Pokechu22, a Mojira mod
- Technically limited to 32767 chars by
PacketByteBuffer#writeString(String)
Given this information, and the commit by md_5 updating Spigot to 1.13-pre7 here only changing the limit from 20 to 32, it seems like a bug in Spigot. During the 1.13 update of Spigot, they should have removed the hard limit.
I'll open an issue on their JIRA link these two.
from fabric-mumblelink-mod.
@BobTagnil I opened an issue on Spigot's JIRA here. Please vote there to encourage it to be resolved faster.
from fabric-mumblelink-mod.
Great !
As a temporary fix I compiled the mod on my computer in order to fix it.
Thank you again for the support of this mumble feature
from fabric-mumblelink-mod.
Can you make it configurable whether the client sends a custom packet? There are still a lot of spigot servers that reject it.
from fabric-mumblelink-mod.
Related Issues (20)
- When I try to build this I get an error and I couldnt fix this HOT 1
- 1.17 support? HOT 4
- 1.17 game crashing when joining a world HOT 3
- not getting "minecraft mumble mod linked" in chat HOT 2
- Ability to change voice channel on disconnect?
- compatibility with mumble 1.4.x snapshots HOT 5
- Mumble Positional Audio not working. (Fabric 1.17.1) HOT 3
- Lunar client and fabric loader mumblelink arent compatible with each other. HOT 1
- camera position as avatar position VS avatar position as camera position HOT 1
- Incompatibility with multiple mods on macOS due to use of AWT classes HOT 4
- Mumble works but not Teamspeak HOT 8
- Coordinate system differs from Forge version HOT 24
- Request - Mod for 1.18 HOT 4
- You'll need a new app to open this mumble link HOT 3
- 1.19.3?
- Inquery: Please provide data for me to compare to ensure compatibility with the ML mod HOT 1
- A question HOT 1
- Add support for Mumble 1.5 HOT 1
- Update mod to 1.20
- Crash in Singleplayer on 1.20
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fabric-mumblelink-mod.