Comments (11)
thorwe
commented on May 30, 2024
1
I figure I may have been a bit cryptic in my answer, so just for the record in more detail:
In API 23 TS added clientId of the sender to the plugin command event (thorwe/CrossTalk@85533c5#diff-36167d09070ef0224839f96a1f443a1eL226), before that I encoded the client id into the string that gets send (thorwe/CrossTalk@85533c5#diff-4d7e408a05b400ecc33508eaadf190c6L911) and parsed it on the receiver (thorwe/CrossTalk@85533c5#diff-36167d09070ef0224839f96a1f443a1eL248).
Little thought was admittedly given about backwards compatibility...
However, a CrossTalk version <1.8.0 will still try to read the client id out of the string, which will fail if the string got composed by the latest version - which sounds suspiciously like the issue reported.
from fabric-mumblelink-mod.
magneticflux-
commented on May 30, 2024
It seems to be an issue in CrossTalk here or here. What version of TeamSpeak and CrossTalk are you using?
from fabric-mumblelink-mod.
PhilippKochendoerfer
commented on May 30, 2024
same problem
MC: 1.15.2
TS: 3.3.0 (18.06.2019 11:29:01)
CT: 1.8.0
Windows 10
from fabric-mumblelink-mod.
magneticflux-
commented on May 30, 2024
I built a version of the CrossTalk plugin with some more debug info and I'll try to reproduce this issue.
from fabric-mumblelink-mod.
magneticflux-
commented on May 30, 2024
I am unable to reproduce this with a local client and server. I can't fix your issues without TeamSpeak and/or Minecraft logs to see what is going wrong.
from fabric-mumblelink-mod.
PhilippKochendoerfer
commented on May 30, 2024
Teamspeak: (i censored the Numbers)
06.03.2020 00:22:24 CrossTalk Info PositionalAudio: New context: 4d696e65637261xxxx
06.03.2020 00:22:24 CrossTalk Info PositionalAudio: New identity: 9c0413dc-a755-388b-bf60-xxx
06.03.2020 00:22:24 CrossTalk Error (TSHelpers::GetClientUID): invalid clientID
06.03.2020 00:22:24 CrossTalk Error (TsVrObjOther::TsVrObjOther): invalid clientID
06.03.2020 00:22:24 CrossTalk Debug PositionalAudio: Received: VR: Minecraft Mumble Link Mod CO: match ID: 9c0413dc-a755-388b-bf60-xxx
06.03.2020 00:22:24 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:24 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:24 CrossTalk Debug PositionalAudio: Received: VR: Minecraft Mumble Link Mod CO: match ID: 9c0413dc-a755-388b-bf60-xxx
06.03.2020 00:22:24 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:24 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:31 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:31 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:41 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:41 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:44 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:44 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:47 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:47 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:48 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:48 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:48 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:48 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:52 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:52 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:55 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:55 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:58 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:58 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:58 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:58 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:59 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:59 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:59 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:59 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:59 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:59 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:22:59 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:22:59 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:00 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:00 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:00 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:00 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:01 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:01 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:01 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:01 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:02 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:02 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:02 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:02 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:03 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:03 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:04 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:04 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:04 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:04 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:04 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:04 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:05 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:05 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:05 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:05 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:05 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:05 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:06 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:06 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:06 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:06 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:06 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:06 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:10 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:10 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:15 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:15 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:19 CrossTalk Error PositionalAudio: (GetSendStringJson): invalid clientID
06.03.2020 00:23:19 CrossTalk Warning TSLogging::PlayErrorSound:Unknown Custom Error (GetSoundPack) Unknown error.
06.03.2020 00:23:31 CrossTalk Info PositionalAudio: Unlocked.
Minecraft:
[01:21:18] [main/INFO]: Loading for game Minecraft 1.15.2
[01:21:22] [main/INFO]: [FabricLoader] Loading 44 mods: [email protected], [email protected]+f08b61330c, [email protected]+e08a73050c, [email protected]+dfdb52d60c, [email protected]+build.184, [email protected], [email protected], [email protected]+9290e2ed0c, [email protected]+b7f9825d0c, [email protected]+203491ea0c, [email protected]+3b05f68e0c, [email protected]+b7f9825d0c, [email protected]+a1bd31180c, [email protected]+build.1, [email protected]+b7f9825d0c, [email protected]+534104900c, [email protected]+534104900c, [email protected], [email protected], [email protected]+b7f9825d0c, [email protected]+06c939b30c, [email protected], [email protected]+821cdba70c, [email protected], [email protected]+b7f9825d0c, [email protected]+abd915800c, [email protected]+12515ed90c, [email protected]+f3d8141b0c, [email protected]+b7f9825d0c, [email protected], [email protected]+c6a8ea890c, [email protected]+b7f9825d0c, [email protected]+5a0f9a600c, [email protected], [email protected]+b7f9825d0c, [email protected]+e08a73050c, [email protected]+build.292-1.15, [email protected]+dfdb52d60c, [email protected]+dfdb52d60c, [email protected]+ec40b2e10c, [email protected]+e4c9a9c30c, [email protected]+12515ed90c, [email protected], [email protected]
[01:21:27] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8 Source=file:/C:/Users/User/Downloads/mmc-stable-win32/MultiMC/libraries/net/fabricmc/sponge-mixin/0.8+build.18/sponge-mixin-0.8+build.18.jar Service=Knot/Fabric Env=CLIENT
[01:21:29] [main/INFO]: Setting user: USERNAME
[01:21:39] [main/INFO]: [Indigo] Registering Indigo renderer!
[01:21:39] [main/INFO]: Backend library: LWJGL version 3.2.2 build 10
[01:21:45] [main/INFO]: Narrator library for x64 successfully loaded
[01:21:45] [main/INFO]: Reloading ResourceManager: Default, Fabric Renderer API (v1), Fabric Networking Block Entity (v0), Fabric Key Bindings (v0), Fabric Renderer - Indigo, Fabric Containers (v0), Fabric Biomes (v1), Fabric Crash Report Info (v1), Fabric Events Interaction (v0), Fabric Language Kotlin, Fabric API Base, Fabric Rendering (v0), Fabric Rendering (v1), Cloth Config v2, Fabric Rendering Data Attachment (v1), Fabric Resource Loader (v0), Auto Config v1 Updated, Fabric Textures (v0), Fabric Content Registries (v0), Fabric Tag Extensions (v0), Fabric Rendering Fluids (v1), Fabric Registry Sync (v0), Fabric Commands (v0), Fabric BlockRenderLayer Registration (v1), Fabric Mining Levels (v0), Fabric Renderer Registries (v1), Fabric Events Lifecycle (v0), Fabric Loot Tables (v1), Fabric API, Fabric Models (v0), Fabric Item Groups (v0), Fabric Object Builders (v0), Fabric Networking (v0), MumbleLink
[01:21:57] [main/INFO]: OpenAL initialized.
[01:21:57] [main/INFO]: Sound engine started
[01:21:57] [main/INFO]: Created: 1024x1024x4 minecraft:textures/atlas/blocks.png-atlas
[01:21:57] [main/INFO]: Created: 256x128x4 minecraft:textures/atlas/signs.png-atlas
[01:21:57] [main/INFO]: Created: 1024x512x4 minecraft:textures/atlas/banner_patterns.png-atlas
[01:21:57] [main/INFO]: Created: 1024x512x4 minecraft:textures/atlas/shield_patterns.png-atlas
[01:21:57] [main/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas
[01:21:57] [main/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas
[01:21:57] [main/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas
[01:21:58] [main/INFO]: Created: 256x256x0 minecraft:textures/atlas/particles.png-atlas
[01:21:58] [main/INFO]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas
[01:21:58] [main/INFO]: Created: 256x128x0 minecraft:textures/atlas/mob_effects.png-atlas
[01:22:17] [main/INFO]: Connecting to localhost, 25565
[01:22:23] [main/INFO]: Loaded 84 advancements
[01:22:24] [main/INFO]: Linking to VoIP client...
[01:22:24] [main/INFO]: Linked
[01:23:12] [main/INFO]: [CHAT] <USERNAME> test
[01:23:22] [main/INFO]: Unlinking from VoIP client...
[01:23:22] [main/INFO]: Unlinked
Maybe its a user error ?
from fabric-mumblelink-mod.
magneticflux-
commented on May 30, 2024
@PhilippKochendoerfer
I have two ideas to try:
- Only use the default "Sound Pack" on TeamSpeak and see if the error still occurs. I'm not sure what sound packs are since I don't use TeamSpeak frequently, but it's appearing alongside the error. If this is the problem, it's probably and issue with CrossTalk itself.
- Try my debug build of CrossTalk and send new logs. I'll attach a binary that you can install manually, and a patch that you can apply to the CrossTalk sources if you wish to build it yourself.
Here's a zip file containing a pre-built x86_64 binary and a patch to build it from source: CrossTalk_debug.zip
I've traced out the source of the error as far as I can right now and I can't find any location in which my mod's data could be used to affect what's causing the error. It appears like the clientID values are passed to the plugin from TeamSpeak and sent directly through to GetSendStringJson.
Here's the path that I traced out:
on_plugin_command(uint64 sch_id, const char * plugin_name, const char * plugin_command, anyID invoker_client_id, const char * invoker_name, const char * invoker_uid) (Plugin)
onPluginCommand(uint64 serverConnectionHandlerID, anyID clientID, bool isMe, QString cmd, QTextStream & args) (PositionalAudio)
Add(uint64 serverConnectionHandlerID, anyID clientID) (TsVrUniverse)
TsVrObjOther(QObject * parent, uint64 serverConnectionHandlerID, anyID clientID) (TsVrObjOther)
GetClientUID(uint64 serverConnectionHandlerID, anyID clientID, QString & result) (TSHelpers)
GetSendStringJson(bool isAll, bool isMe, TsVrObj * obj) (PositionalAudio)
from fabric-mumblelink-mod.
magneticflux-
commented on May 30, 2024
@thorwe, do you have any insight into this issue? Is there something wrong with my implementation?
from fabric-mumblelink-mod.
thorwe
commented on May 30, 2024
I changed the protocol for the API 23 where it's not necessary anymore to
pass the client id manually without adding legacy support.
Most likely there's a mix of different Crosstalk versions involved. Make
sure they're all using 1.8.0 from
https://www.myteamspeak.com/addons/9ddfa0b2-25c2-4302-8a43-07f8819af9a9
Error should go away then.
…On Fri, Mar 6, 2020 at 5:01 PM Mitchell Skaggs ***@***.***> wrote:
@thorwe <https://github.com/thorwe>, do you have any insight into this
issue? Is there something wrong with my implementation?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/magneticflux-/fabric-mumblelink-mod/issues/20?email_source=notifications&email_token=AAXKAB54AGPDF22RJ7E3OXLRGEM7NA5CNFSM4KDLBUBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOB3WEQ#issuecomment-595835666>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXKABZYPF4HEWI5ML6M6NDRGEM7NANCNFSM4KDLBUBA>
.
from fabric-mumblelink-mod.
magneticflux-
commented on May 30, 2024
@thorwe
Thanks for the help!
@Lazare-C @PhilippKochendoerfer
Please try again using the latest versions of TeamSpeak and CrossTalk, and make sure the other members also use the latest versions too.
If it appears that updating fixes the issue or there's no new activity in a few days, I'll close this as resolved.
from fabric-mumblelink-mod.
magneticflux-
commented on May 30, 2024
Closing as it seems the issue is resolved. Feel free to comment/reopen if there are still issues after following @thorwe's advice!
from fabric-mumblelink-mod.
Related Issues (20)
- When I try to build this I get an error and I couldnt fix this HOT 1
- 1.17 support? HOT 4
- 1.17 game crashing when joining a world HOT 3
- not getting "minecraft mumble mod linked" in chat HOT 2
- Ability to change voice channel on disconnect?
- compatibility with mumble 1.4.x snapshots HOT 5
- Mumble Positional Audio not working. (Fabric 1.17.1) HOT 3
- Lunar client and fabric loader mumblelink arent compatible with each other. HOT 1
- camera position as avatar position VS avatar position as camera position HOT 1
- Incompatibility with multiple mods on macOS due to use of AWT classes HOT 4
- Mumble works but not Teamspeak HOT 8
- Coordinate system differs from Forge version HOT 24
- Request - Mod for 1.18 HOT 4
- You'll need a new app to open this mumble link HOT 3
- 1.19.3?
- Inquery: Please provide data for me to compare to ensure compatibility with the ML mod HOT 1
- A question HOT 1
- Add support for Mumble 1.5 HOT 1
- Update mod to 1.20
- Crash in Singleplayer on 1.20
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fabric-mumblelink-mod.