Country validator is causing problems about ipay88

[codekipple]

Oh forgot to say, to replicate this issue, try setting the country code to empty in the PHP serialised string in the sales_payment_transaction table on the record with a type of capture in the additional_information field. e.g. S_country";s:0:"".

Then in the admin on the order list select the order and then choose 'Print Invoices' from the Actions dropdown list.

When I do that on an order with no two letter country code set in the sales_payment_transaction table I get the error (see attached image).

[dmitrii-fediuk]

What is your website?

[codekipple]

Hi Dmitry ,
I have emailed [email protected] to confirm the website url.

[dmitrii-fediuk]

Please provide me:

1. SSH access to your website's server.
2. An exact order which reproduces the described problem (without any manual database modifications).

I want to analyse the full order's data to understand why is the country code empty and to implement the best solution.

[codekipple]

Sorry Dmitry I won't be able to give you SSH access.
I can debug the issue with you collaboratively over slack or Skype and provide you with data as you request if you wanted to do it that way.

I think the issue is partly ipay88's problem, for some reason it sometimes just doesn't return the two letter country code. From your modules perspective I just think the best fix is to make your plugin be able to handle that. So currently if ipay88 does not provide a two letter country code in it's response your plugin fails.

This scenario is intermittent, it only happens to us about once every two months.

I can dig into your code a bit and try to find a solution myself, if I manage too I can provide you with a pull request.

[dmitrii-fediuk]

Fixed in 1.5.2.