Comments (6)
I wondered that you talk about push_allowances
, because we used push_restrictions
until now. Turned out we need a Terraform update, which I executed in #86.
Your suggestions sound good to me. I'd personally say we can go with the slightly "less secure" option 2. However, I don't feel comfortable deciding this alone. Hence, I'm dragging in the @mage-os/infrastructure team, @Vinai @damienwebdev @DavidLambauer.
from terraform.
@Vinai, @damienwebdev, @DavidLambauer, could someone share their opinion on this one?
from terraform.
I don't have enough familiarity with this to comment.
from terraform.
If you wouldn't mind a random flyby, I would strongly recommend that option 2 not be taken lightly.
It would be better to be as explicit as possible. Id suggest either by allowing for a new item within your objects or a user to repo map that is considered during branch rule/branch protection setup. This way you dont have issues aligning global changes, and your user doesnt get additional privelages in much more repos than necessary.
from terraform.
We can loosen the permissions, as it would also benefit me in the DevDocs repository. Permissions should be managed at the user level.
from terraform.
I think keeping the setup more secure by default is the way to go.
from terraform.
Related Issues (20)
- New repo for mage-os contribution environments HOT 2
- Mirrors need to allow force pushes
- Add Support For Individual Contributors
- Set Default Branch for Specific Repositories HOT 1
- Support Archiving Repositories
- Add Topics HOT 3
- Incompatibility Between github_team_repository and github_repository_collaborator
- The Terraform Bot is the wrong user (in Git)
- fix: terraform attempts to change the CODEOWNERS on archived repos HOT 10
- merge-upstream-changes.yml workflow not created in mageos-magento2-functional-testing-framework repo HOT 3
- Change code owner for mage-os/github-actions to infrastructure team HOT 1
- Workflows On Inactive Repositories Should Remain Enabled
- Switch to openTF?
- Branch Protection Setting for mage-os/github-actions should only be `main` HOT 5
- mage-os/mirror-magento-coding-standard missing merge-upstream-changes workflow HOT 1
- `hacktoberfest` topic on `github-actions`
- Add mage-os/magento-gitpod
- Issues With Archived Repositories HOT 4
- Merging is blocked HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform.