Coder Social home page Coder Social logo

Comments (3)

csharplus avatar csharplus commented on September 27, 2024

@wangxiaoyou1993 workspace_default_config does not show up in the code at all. Based on the current implementation of repo_manager.py, should this variable be renamed to workspace_shared_config instead?

...
        self.variables_dir = None
        self.variables_retention_period = None
        self.workspace_initial_metadata = None
        self.workspace_shared_config = None
...

from mage-ai.

mangobillbay avatar mangobillbay commented on September 27, 2024

Um, I don't really get it... I might have misunderstand the code, but I'll try to clarify my point:

In the repo_manager.py (at line 147) I can see it reads config from workspace_config_defaults.

However in the provided template for metadata.yaml (at line 10) there is an object/section called workspace_default_config.

I believe the idea is that these names should match, but they don't. So when I use the provided template and make changes to the default workspace configuration it nothing happens. If I change (correct?) the name in the template file it works as expected.

So my suggestion is to change the name in the metadata.yaml from workspace_default_config to workspace_config_defaults.

from mage-ai.

wangxiaoyou1993 avatar wangxiaoyou1993 commented on September 27, 2024

It might be a name mismatch. We'll fix it.

from mage-ai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.