Coder Social home page Coder Social logo

Comments (13)

kenneymyers avatar kenneymyers commented on May 20, 2024 1

I went ahead and pulled down the source and just fixed it in the CacheFirstSafe.js, CacheFirst.js, and NetworkFirst.js. It seems to work well. Thank you!

from webessentials.aspnetcore.serviceworker.

Siderite avatar Siderite commented on May 20, 2024

The docs say that the Web cache API can only put http/https requests (https://developer.mozilla.org/en-US/docs/Web/API/Cache/put#Return_value). So this can be solved by adding a check in code like:

caches.open(version)
            .then(function (cache) {
                // here be the fix
                if (!/^https?:$/i.test(new URL(request.url).protocol)) return;
                cache.put(request, copy);
            });

used in CacheFingerprinted.js and CacheFirstSafe.js

from webessentials.aspnetcore.serviceworker.

Darkace01 avatar Darkace01 commented on May 20, 2024

The docs say that the Web cache API can only put http/https requests (https://developer.mozilla.org/en-US/docs/Web/API/Cache/put#Return_value). So this can be solved by adding a check in code like:

caches.open(version)
            .then(function (cache) {
                // here be the fix
                if (!/^https?:$/i.test(new URL(request.url).protocol)) return;
                cache.put(request, copy);
            });

used in CacheFingerprinted.js and CacheFirstSafe.js

How do we add this to our code?

from webessentials.aspnetcore.serviceworker.

Darkace01 avatar Darkace01 commented on May 20, 2024

I think I found a fix to it
caches.open(version) .then(function (cache) { // here be the fix if(request.url.match("^(http|https)://")){ cache.put(request, copy); }else{ return; }

from webessentials.aspnetcore.serviceworker.

jolugama avatar jolugama commented on May 20, 2024

yes, it's works. Thanks

from webessentials.aspnetcore.serviceworker.

kenneymyers avatar kenneymyers commented on May 20, 2024

I think I found a fix to it
caches.open(version) .then(function (cache) { // here be the fix if(request.url.match("^(http|https)://")){ cache.put(request, copy); }else{ return; }

How did you apply this fix? Is this something that can be merged into the nuget package so we can all benefit from the fix?

from webessentials.aspnetcore.serviceworker.

Darkace01 avatar Darkace01 commented on May 20, 2024

I think I found a fix to it
caches.open(version) .then(function (cache) { // here be the fix if(request.url.match("^(http|https)://")){ cache.put(request, copy); }else{ return; }

How did you apply this fix? Is this something that can be merged into the nuget package so we can all benefit from the fix?

I added that in my service worker.js file

I don't know if it could be added to the nugget package

I can try to figure out a way to make a pull request to the repo to fix this

from webessentials.aspnetcore.serviceworker.

Darkace01 avatar Darkace01 commented on May 20, 2024

I went ahead and pulled down the source and just fixed it in the CacheFirstSafe.js, CacheFirst.js, and NetworkFirst.js. It seems to work well. Thank you!

#84

Check out this pull request if it would help

from webessentials.aspnetcore.serviceworker.

xbaha avatar xbaha commented on May 20, 2024

I got the same error, is this going to be merged in the next release?

from webessentials.aspnetcore.serviceworker.

Darkace01 avatar Darkace01 commented on May 20, 2024

I think @madskristensen is working on the next release

from webessentials.aspnetcore.serviceworker.

Darkace01 avatar Darkace01 commented on May 20, 2024

I got the same error, is this going to be merged in the next release?

Also I think you can just update your service worker directly before the release

from webessentials.aspnetcore.serviceworker.

xbaha avatar xbaha commented on May 20, 2024

How do I update the service worker??

from webessentials.aspnetcore.serviceworker.

Darkace01 avatar Darkace01 commented on May 20, 2024

you can create the service worker file but I think it is auto-created when you install the package

from webessentials.aspnetcore.serviceworker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.