Comments (13)
I went ahead and pulled down the source and just fixed it in the CacheFirstSafe.js, CacheFirst.js, and NetworkFirst.js. It seems to work well. Thank you!
from webessentials.aspnetcore.serviceworker.
The docs say that the Web cache API can only put http/https requests (https://developer.mozilla.org/en-US/docs/Web/API/Cache/put#Return_value). So this can be solved by adding a check in code like:
caches.open(version)
.then(function (cache) {
// here be the fix
if (!/^https?:$/i.test(new URL(request.url).protocol)) return;
cache.put(request, copy);
});
used in CacheFingerprinted.js and CacheFirstSafe.js
from webessentials.aspnetcore.serviceworker.
The docs say that the Web cache API can only put http/https requests (https://developer.mozilla.org/en-US/docs/Web/API/Cache/put#Return_value). So this can be solved by adding a check in code like:
caches.open(version) .then(function (cache) { // here be the fix if (!/^https?:$/i.test(new URL(request.url).protocol)) return; cache.put(request, copy); });
used in CacheFingerprinted.js and CacheFirstSafe.js
How do we add this to our code?
from webessentials.aspnetcore.serviceworker.
I think I found a fix to it
caches.open(version) .then(function (cache) { // here be the fix if(request.url.match("^(http|https)://")){ cache.put(request, copy); }else{ return; }
from webessentials.aspnetcore.serviceworker.
yes, it's works. Thanks
from webessentials.aspnetcore.serviceworker.
I think I found a fix to it
caches.open(version) .then(function (cache) { // here be the fix if(request.url.match("^(http|https)://")){ cache.put(request, copy); }else{ return; }
How did you apply this fix? Is this something that can be merged into the nuget package so we can all benefit from the fix?
from webessentials.aspnetcore.serviceworker.
I think I found a fix to it
caches.open(version) .then(function (cache) { // here be the fix if(request.url.match("^(http|https)://")){ cache.put(request, copy); }else{ return; }
How did you apply this fix? Is this something that can be merged into the nuget package so we can all benefit from the fix?
I added that in my service worker.js file
I don't know if it could be added to the nugget package
I can try to figure out a way to make a pull request to the repo to fix this
from webessentials.aspnetcore.serviceworker.
I went ahead and pulled down the source and just fixed it in the CacheFirstSafe.js, CacheFirst.js, and NetworkFirst.js. It seems to work well. Thank you!
Check out this pull request if it would help
from webessentials.aspnetcore.serviceworker.
I got the same error, is this going to be merged in the next release?
from webessentials.aspnetcore.serviceworker.
I think @madskristensen is working on the next release
from webessentials.aspnetcore.serviceworker.
I got the same error, is this going to be merged in the next release?
Also I think you can just update your service worker directly before the release
from webessentials.aspnetcore.serviceworker.
How do I update the service worker??
from webessentials.aspnetcore.serviceworker.
you can create the service worker file but I think it is auto-created when you install the package
from webessentials.aspnetcore.serviceworker.
Related Issues (20)
- Uncaught (in promise) when upgrading from 1.0.65 to 1.085 HOT 3
- Switch to System.Text.Json
- errors after configuring pwa with WebEssentials.AspNetCore.PWA HOT 1
- Multi Language
- Error Publish Server HOT 1
- Doubled registration
- service worker is not being registered and rendered when .NET core 5 app is published into IIS HOT 7
- iOS Install App Prompt Workarounds? HOT 4
- Bad Response + Manifest: Line: 1, column: 1, Syntax error. + Failed to register a ServiceWorker HOT 3
- unable to add to blazor server project
- ADB2C infinite loop HOT 1
- Error Activate
- WebManifest.IsValid implementation is wrong
- Google and Linkedin OAuth Fails in iOS and Safari browser on MacOS after adding service worker
- Failed to execute 'put' on 'Cache' HOT 1
- No matching service worker detected when accessed using IP
- Obsolete reference to "NWebsec.AspNetCore.Mvc.TagHelpers" HOT 1
- How to fix "Site cannot be installed: Page is not served from a secure origin"? HOT 1
- Move to framework reference HOT 5
- Add licence type to Nuget Package
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webessentials.aspnetcore.serviceworker.