Proxying requests through another server causes VS to crash about browserreloadonsave

[madskristensen]

Thanks for reporting this. What type of project are you using (ASP.NET Core/5, ASP.NET MVC 4/5, WebForms, or...?)

[ctolkien]

Hey Mads,

This is a regular MVC 5 site. Let me know if I can trial the above fix in a build somehow and I'll give it a whirl.

[madskristensen]

The latest CI build is here for testing http://vsixgallery.com/extension/2d8aa02a-8810-421f-97b9-86efc573fea3/

[ctolkien]

No dice, here's a better stack trace:

System.Transactions Critical: 0 : http://msdn.microsoft.com/TraceCodes/System/ActivityTracing/2004/07/Reliability/Exception/UnhandledUnhandled exceptionDefaultDomainSystem.ArgumentNullException, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089Value cannot be null.
Parameter name: key at System.Collections.Generic.Dictionary2.FindEntry(TKey key) at BrowserReloadOnSave.ReloadFactory.CreateExtensionInstance(BrowserLinkConnection connection) in C:\projects\browserreloadonsave\src\BrowserLink\ReloadFactory.cs:line 28 at Microsoft.VisualStudio.Web.BrowserLink.FactoryManager.CreateExtensionsForConnection(BrowserLinkConnection connection) at Microsoft.VisualStudio.Web.BrowserLink.FactoryManager.PreConnected(Object sender, ConnectionEventArgs e) at Microsoft.VisualStudio.Web.BrowserLink.ConnectionsImpl.FirePreConnected(BrowserLinkConnection connection) at Microsoft.VisualStudio.Web.BrowserLink.ConnectionsImpl.AddConnection(BrowserLinkConnection connection) at Microsoft.VisualStudio.Web.BrowserLink.SignalRSelfHost.ArteryConnection.&amp;lt;&amp;gt;c__DisplayClass8_0.&amp;lt;OnConnected&amp;gt;b__0() at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs) at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler) at System.Windows.Threading.DispatcherOperation.InvokeImpl() at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Windows.Threading.DispatcherOperation.Invoke() at System.Windows.Threading.Dispatcher.ProcessQueue() at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean&amp;amp; handled) at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean&amp;amp; handled) at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs) at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler) at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs) at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)</StackTrace><ExceptionString>System.ArgumentNullException: Value cannot be null. Parameter name: key at System.Collections.Generic.Dictionary2.FindEntry(TKey key)
at BrowserReloadOnSave.ReloadFactory.CreateExtensionInstance(BrowserLinkConnection connection) in C:\projects\browserreloadonsave\src\BrowserLink\ReloadFactory.cs:line 28
at Microsoft.VisualStudio.Web.BrowserLink.FactoryManager.CreateExtensionsForConnection(BrowserLinkConnection connection)
at Microsoft.VisualStudio.Web.BrowserLink.FactoryManager.PreConnected(Object sender, ConnectionEventArgs e)
at Microsoft.VisualStudio.Web.BrowserLink.ConnectionsImpl.FirePreConnected(BrowserLinkConnection connection)
at Microsoft.VisualStudio.Web.BrowserLink.ConnectionsImpl.AddConnection(BrowserLinkConnection connection)
at Microsoft.VisualStudio.Web.BrowserLink.SignalRSelfHost.ArteryConnection.<>c__DisplayClass8_0.<OnConnected>b__0()
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
at System.Windows.Threading.DispatcherOperation.InvokeImpl()
at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Windows.Threading.DispatcherOperation.Invoke()
at System.Windows.Threading.Dispatcher.ProcessQueue()
at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)

[madskristensen]

Thanks, that's much better. I can see what the issue is now and a fix is coming. It appears that when you're using the proxy, Browser Link can't find the project for the connection and that's what causes the issue. I have a fix coming in a few minutes.

[madskristensen]

The latest version is ready in a few minutes on the same URL as before. This won't make the extension work for your particular project, but it will prevent VS from crashing

[ctolkien]

That's fixed it!

This won't make the extension work for your particular project, but it will prevent VS from crashing

Yep, as long as VS doesn't fall over, all good 👍

[madskristensen]

Thanks so much for the stack trace. Very much appreciated!!