info result about nodemw

[macbre]

Take a look at https://github.com/macbre/nodemw/blob/master/lib/api.js#L170

Callback passed to this.api.call is provided with a following parameters:

callback(info, next, data);

data contains "raw" data returned by API. That's the one with data you're interested to get from the server.

[vid]

I'm sorry that I don't quite understand this, maybe it's because of my head cold. =) Does one of the other API calls provide an example?

I did implement a solution for this in my own code.

    getAsk: function(params, callback) {
        params.action = 'ask';
        params.resultKW = 'query';

        this.api.call(params).then(function(res) {
            callback && callback(res);
        });
    },

then in api.php:

                info = data && data[params.resultKW || actionName];

[macbre]

If you're using a promise pattern, you should do the following:

    function(params, callback) {
        params.action = 'ask';
        params.resultKW = 'query';

        this.api.call(params).then(function(res) {
            callback && callback(res.data && res.data.results);
        });
    }

https://github.com/macbre/nodemw/blob/master/lib/api.js#L182

[vid]

is code as intended?

https://github.com/macbre/nodemw/blob/master/lib/api.js#L171

shouldn't it be something like:

data[actionName] || data ?

otherwise it doesn't seem like the following block will get executed if the actionName doesn't match the return key.

https://github.com/macbre/nodemw/blob/master/lib/api.js#L178-L187

[macbre]

Yeah, good point!

An if block at line 178 should be changed to allow that kind of responses to pass.

[vid]

is this a change you can make? I don't quite understand the intent of this section of code (if there's going to be an else to pass it through anyway, why make an if at all). If you can do that, I can commit some additional actions.

I would like to add some code supporting emerging SMW javascript support, would this be ok to add to nodemw or can it be made modular?

thanks!

[macbre]

Sure, I'll make this change.

Then, fell free to add SMW specific actions :)

[macbre]

Done in f12f420