Coder Social home page Coder Social logo

Comments (10)

fwartner avatar fwartner commented on May 18, 2024 4

Submitted the PR: #55930

Thank you for your support! :)

from mac-cleanup-sh.

shin-sforzando avatar shin-sforzando commented on May 18, 2024 4

@fwartner Thank you for adding MIT License.
I'm rooting for you!

from mac-cleanup-sh.

piersolenski avatar piersolenski commented on May 18, 2024 4

@fwartner Homebrew/homebrew-core#55930 (comment) would you mind opening a new PR? Would be awesome to get this on Homebrew!

from mac-cleanup-sh.

fwartner avatar fwartner commented on May 18, 2024 3

Done :)

from mac-cleanup-sh.

shin-sforzando avatar shin-sforzando commented on May 18, 2024 1

Has anyone started this issue?
I made a LGTM Formula, but it's the author's prerogative to push it to Homebrew.

class MacCleanup < Formula
  desc "Cleanup script for OSX"
  homepage "https://github.com/fwartner/mac-cleanup/"
  url "https://github.com/fwartner/mac-cleanup/archive/1.0.2.tar.gz"
  sha256 "52c454c9abac16801814a90d766ff1d7367a698b0e003bc3dfe02cdfde6d1fa6"

  def install
    chmod 0755, "cleanup.sh"
    bin.install "cleanup.sh" => "cleanup"
  end

  test do
    system "#{bin}/cleanup"
  end
end

Screen Shot 2020-06-07 at 1 45 56

I sincerely hope it's officially approved.

from mac-cleanup-sh.

nitrocode avatar nitrocode commented on May 18, 2024 1

O, really? Where is it written?
As you can see, my formula is referring to this branch's release URL.
If @fwartner and core contributors doesn't do the same Release, it won't work. So I'd like to leave the PR to Homebrew to the author, if possible.

I was referring to this

We frown on authors submitting their own work unless it is very popular.

From Acceptable-Formulae#niche-or-self-submitted-stuff but I suppose it meets the criteria of "very popular" due to the star count.

from mac-cleanup-sh.

fwartner avatar fwartner commented on May 18, 2024

Well that´s a great idea!

from mac-cleanup-sh.

nitrocode avatar nitrocode commented on May 18, 2024

Nice job! Actually the homebrew community discourages repo owners from submitting formula for their own projects.

if you put in a pr for the formula above, there's a good chance that they will accept it and we can all benefit.

from mac-cleanup-sh.

shin-sforzando avatar shin-sforzando commented on May 18, 2024

Nice job! Actually the homebrew community discourages repo owners from submitting formula for their own projects.

O, really? Where is it written?
As you can see, my formula is referring to this branch's release URL.
If @fwartner and core contributors doesn't do the same Release, it won't work. So I'd like to leave the PR to Homebrew to the author, if possible.

from mac-cleanup-sh.

shin-sforzando avatar shin-sforzando commented on May 18, 2024

My pleasure:)

from mac-cleanup-sh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.