Coder Social home page Coder Social logo

list-contributors's People

Contributors

github-actions[bot] avatar maanuj-vora avatar mrstandu33 avatar zepatrik avatar

Stargazers

avatar avatar avatar avatar

Watchers

avatar avatar

Forkers

ory mrstandu33 sourceblocks

list-contributors's Issues

Generated HTML does not comply with W3C standards

When using this action, we get an HTML as this one : (example took from this action README file.)

<html><table><tr><td align="center"><a href=https://github.com/apps/github-actions><img src=https://avatars.githubusercontent.com/in/15368?v=4 width="50;" alt=apps/github-actions/><br /><sub style="font-size:14px"><b>apps/github-actions</b></sub></a></td><td align="center"><a href=https://github.com/Maanuj-Vora><img src=https://avatars.githubusercontent.com/u/31610859?v=4 width="50;" alt=Maanuj Vora/><br /><sub style="font-size:14px"><b>Maanuj Vora</b></sub></a></td><td align="center"><a href=https://github.com/zepatrik><img src=https://avatars.githubusercontent.com/u/5354445?v=4 width="50;" alt=Patrik/><br /><sub style="font-size:14px"><b>Patrik</b></sub></a></td></tr></table></html>

pretty version :

<html>
  <table>
    <tr>
      <td align="center">
        <a href=https://github.com/apps/github-actions>
          <img src=https://avatars.githubusercontent.com/in/15368?v=4 width="50;" alt=apps/github-actions/><br />
          <sub style="font-size:14px">
            <b>apps/github-actions</b>
          </sub>
        </a>
      </td>
      <td align="center">
        <a href=https://github.com/Maanuj-Vora>
          <img src=https://avatars.githubusercontent.com/u/31610859?v=4 width="50;" alt=Maanuj Vora/><br />
          <sub style="font-size:14px">
            <b>Maanuj Vora</b>
          </sub>
        </a>
      </td>
      <td align="center">
        <a href=https://github.com/zepatrik>
          <img src=https://avatars.githubusercontent.com/u/5354445?v=4 width="50;" alt=Patrik/><br />
          <sub style="font-size:14px">
            <b>Patrik</b>
          </sub>
        </a>
      </td>
    </tr>
  </table>
</html>

As you can see, a and img tags attributes does not have any quotes enclosing attributes values, causing HTML parsers to struggle to handle the readme file.

The HTML also adds trailing / on void elements (ie. <br />), and W3C validator complains about it
(see this and that)

I suggest adding enclosing quotes around attribute values and removes trailings slashes on void elements, as it do not implies any breaking changes and complies with W3C standards.

I will do a pull request later, that I will link to this issue.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.