node 14 about async-busboy

[alqu]

Thanks for merging @amit777. Please update the npm package :-)

[Sceat]

still hang on node 16

[m4nuC]

1.1.0 published to NPM. Apologies to everyone for the delay

[amit777]

Hi @FredericHeem and @alqu would you mind testing my fork with the fixes here: https://github.com/amit777/async-busboy

It seems to work for me.

[ogarich89]

Same problem. Had to use @koa/multer =(

[alqu]

Same here. Any solution in sight?

[amit777]

Also noticed upload issue on node14. Works on node 12. Using v1.0.1

[amit777]

I've been debugging this. While I thought the code would always hang, I did actally see it succesfully work twice while I was putting console logs in.. I thought maybe the console.log was somehow causing it to start working, but it doesn't seem to be the case.. so it seems like it will fail most of the time but may occasionally work.

[amit777]

ok.. I think i've found the culprit. busboy's "close" event seems to be firing before "finished". When this happens, the finished event gets unsubscribed to, and the Promise is not resolved. I'm not sure if some assumption changed in Node14 streams about the order of events.

busboy.on('close', cleanup);

[imox2]

@amit777 yep, thats the culprit. I too found that

Also, don't you think
busboy.on('close', cleanup) is required for some other case. So maybe removing that will solve this case but break anything else?

Also, I was more interested in finding why is close called early. Maybe something changed in node 14

[amit777]

in my pull request I did remove the .on('close') since it only calls cleanup(). Cleanup looks like it would get call anyway later by another event, so I think it may not be impactful, but I'm not sure.

Out of curious, what tool did you use that generated that output from your screenshot?

[alqu]

Hi @FredericHeem and @alqu would you mind testing my fork with the fixes here: https://github.com/amit777/async-busboy

It seems to work for me.

I tested it locally and on a production server - it works fine, no problems so far.

[FredericHeem]

@amit777 thanks a lot, confirmation from my side your fork is working fine. Waiting for the package to be published.

[lehmamic]

have the same problem, waiting as well...

[fjeddy]

Guess we can consider this repo dead.

[amit777]

@m4nuC would it be possible to publish the updated package on npm? It looks like a lot of testers confirmed it works.

[m4nuC]

@amit777 on it. Sorry for the delay

[Uzlopak]

Do you set autoDestroy to false?