Coder Social home page Coder Social logo

Supporting AtomsBase about celllistmap.jl HOT 7 OPEN

m3g avatar m3g commented on August 21, 2024
Supporting AtomsBase

from celllistmap.jl.

Comments (7)

lmiq avatar lmiq commented on August 21, 2024

Hi @rkurchin, AtomsBase is definitely on my radar. This package in particular is very general and arguably one can use it with any type of "particle". Some of my other packages like PDBTools.jl and (the recent) MolecularMinimumDistances.jl are probably suited to have standard interfaces with the rest of the ecosystem.

from celllistmap.jl.

rkurchin avatar rkurchin commented on August 21, 2024

I saw MolecularMinimumDistances, but it seems it just depends on this for its structural representations, which was why I thought that this one made sense for AtomsBase. I could imagine a way for the CellList object to subtype AbstractSystem and dispatch the interface in a relatively straightforward way. Actually, probably a single Cell could and then the dispatch onto CellList could make use of those dispatches...let me know if this all sounds crazy 😛

from celllistmap.jl.

lmiq avatar lmiq commented on August 21, 2024

Uhm... I see what you mean. I suppose that if a System (an AbstractSystem) has some standard data structure containing the periodic boundary conditions and coordinates, there could be a shortcut to use CellListMap in which we didn't need to specify them explicitly with the CellListMap interface. That may make sense. I will take a closer look at the interface exposed by AtomsBase to see how that could be done.

from celllistmap.jl.

rkurchin avatar rkurchin commented on August 21, 2024

The AtomsBase interface doesn't demand any particular internal data structure (which we see as a major strength), it just needs a small set of functions (e.g. to return a list of atomic positions) dispatched. If it would be helpful, I can start a draft PR showing you a way I could imagine to do it and we can iterate on that. But it would probably be worthwhile for you to get a sense of the interface anyway, so LMK if you'd rather just do it yourself.

from celllistmap.jl.

lmiq avatar lmiq commented on August 21, 2024

I think the most important is for me to understand what can be useful in terms of that interface, for others to use. CellListMap accepts coordinates as vectors of vectors or matrices as input, with units, so there should be no major problem there, but these are inputs for CellListMap. The output can pretty much anything desired by the user.

from celllistmap.jl.

rkurchin avatar rkurchin commented on August 21, 2024

In my mind, the utility would be to take `AbstractSystem objects as input so that someone like @jgreener64, who develops Molly.jl, which uses AtomsBase, could easily use his systems as direct inputs into CellListMap without needing to write more "interface code" to extract things into the right format or whatever...

from celllistmap.jl.

lmiq avatar lmiq commented on August 21, 2024

I am open to implement anything that helps on that direction (Molly.jl is already using CellLIstMap :-) ). The thing is that CellListMap can compute "anything", so what exactly to expect from the interface must be more precise, so it can be useful.

from celllistmap.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.