Comments (7)
Hi @rkurchin, AtomsBase is definitely on my radar. This package in particular is very general and arguably one can use it with any type of "particle". Some of my other packages like PDBTools.jl and (the recent) MolecularMinimumDistances.jl are probably suited to have standard interfaces with the rest of the ecosystem.
from celllistmap.jl.
I saw MolecularMinimumDistances, but it seems it just depends on this for its structural representations, which was why I thought that this one made sense for AtomsBase. I could imagine a way for the CellList
object to subtype AbstractSystem
and dispatch the interface in a relatively straightforward way. Actually, probably a single Cell
could and then the dispatch onto CellList
could make use of those dispatches...let me know if this all sounds crazy
from celllistmap.jl.
Uhm... I see what you mean. I suppose that if a System
(an AbstractSystem
) has some standard data structure containing the periodic boundary conditions and coordinates, there could be a shortcut to use CellListMap in which we didn't need to specify them explicitly with the CellListMap interface. That may make sense. I will take a closer look at the interface exposed by AtomsBase to see how that could be done.
from celllistmap.jl.
The AtomsBase interface doesn't demand any particular internal data structure (which we see as a major strength), it just needs a small set of functions (e.g. to return a list of atomic positions) dispatched. If it would be helpful, I can start a draft PR showing you a way I could imagine to do it and we can iterate on that. But it would probably be worthwhile for you to get a sense of the interface anyway, so LMK if you'd rather just do it yourself.
from celllistmap.jl.
I think the most important is for me to understand what can be useful in terms of that interface, for others to use. CellListMap accepts coordinates as vectors of vectors or matrices as input, with units, so there should be no major problem there, but these are inputs for CellListMap. The output can pretty much anything desired by the user.
from celllistmap.jl.
In my mind, the utility would be to take `AbstractSystem objects as input so that someone like @jgreener64, who develops Molly.jl, which uses AtomsBase, could easily use his systems as direct inputs into CellListMap without needing to write more "interface code" to extract things into the right format or whatever...
from celllistmap.jl.
I am open to implement anything that helps on that direction (Molly.jl is already using CellLIstMap :-) ). The thing is that CellListMap can compute "anything", so what exactly to expect from the interface must be more precise, so it can be useful.
from celllistmap.jl.
Related Issues (20)
- add break and return value if a conditions is found
- add more extensive testing to UpdateCellList HOT 1
- Document the use of `strip_value` HOT 1
- Type declarations of Box HOT 4
- Pair counts changing depending on number of threads HOT 4
- Box constructor is type-unstable
- Simplify dispatch of UpdateCellList! ?
- Is GPU support being planned? HOT 2
- Error on cross pair velocity histogram HOT 2
- This can be a warning. HOT 1
- Control number of threads HOT 2
- Provide an integration example with Agents.jl HOT 1
- Units issue with triclinic box HOT 3
- primitive neighbor list HOT 9
- Birth Death processes...? HOT 3
- per particle cutoff array... HOT 2
- simplify output conversion for numpy arrays
- dealing with highly non-homogeneous systems HOT 6
- Error when creating PeriodicSystem with empty positions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from celllistmap.jl.