Dialog service implementation inhibits extension. about angular-dialog-service

[m-e-conroy]

Hey, thanks. I'll add it as an enhancement in my todo, unless you feel like forking the repo and adding a pull request.

[m-e-conroy]

I just uploaded the changes to the master branch. I actually when ahead and did this for all service calls and original controllers, hopefully you'll be able to decorate which ever one you wish. Let me know if works.

[m-e-conroy]

Sorry, just wanted to say. I haven't minified it yet. so if you want to try it, you'll need dialogs.js not dialogs.min.js

[mark0978]

I was going to fork it, but since you already got it, I'm gonna just go right ahead and use it.

Thanks.

[m-e-conroy]

Ok I minified dialogs.js and pushed up a new release version 5.1.2. Thanks for the help.

[m-e-conroy]

@mark0978 5.1.2 had a typo, its been corrected in 5.1.3

[mark0978]

I've had to make a few changes to get data on the local scope, but its not ready for a PR yet, however I'm running into this problem

now that I'm on 5.1.3 and was wondering why that would be happening. At this point, the only extending I have done is:

            $delegate.requestFailed = function(reason) {
                $log.error(reason);
                if(reason.status === 500) {
                    $delegate.error(reason.statusText, reason.data);
                } ...
            };

So I'm not sure why the translation isn't being done. I'm looking into it now.

[mark0978]

Turns out I had failed to add 'dialogs.default-translations', to my app module list.

[m-e-conroy]

You beat me to it. I saw your email about the trouble but its such a pain to type out a message on a phone so I thought I'd wait to get to my office to message you back.

That was the first thing I thought of, that you hadn't added the translations to your application module. I had to do this because there were others complaining to me that they were already using angular.translate in their application elsewhere and that the automatic inclusion in the dialog service was overwriting their translations. I had to separate it out and make it mandatory to include the default-translations as part of using the dialog services.

I'm going to look into easing that a bit, perhaps have some kind of fall back if someone forgets to include the default module as you did.

Sorry about that Mark.