Comments (9)
Hey, thanks. I'll add it as an enhancement in my todo, unless you feel like forking the repo and adding a pull request.
from angular-dialog-service.
I just uploaded the changes to the master branch. I actually when ahead and did this for all service calls and original controllers, hopefully you'll be able to decorate which ever one you wish. Let me know if works.
from angular-dialog-service.
Sorry, just wanted to say. I haven't minified it yet. so if you want to try it, you'll need dialogs.js not dialogs.min.js
from angular-dialog-service.
I was going to fork it, but since you already got it, I'm gonna just go right ahead and use it.
Thanks.
from angular-dialog-service.
Ok I minified dialogs.js and pushed up a new release version 5.1.2. Thanks for the help.
from angular-dialog-service.
@mark0978 5.1.2 had a typo, its been corrected in 5.1.3
from angular-dialog-service.
I've had to make a few changes to get data on the local scope, but its not ready for a PR yet, however I'm running into this problem
now that I'm on 5.1.3 and was wondering why that would be happening. At this point, the only extending I have done is:
$delegate.requestFailed = function(reason) {
$log.error(reason);
if(reason.status === 500) {
$delegate.error(reason.statusText, reason.data);
} ...
};
So I'm not sure why the translation isn't being done. I'm looking into it now.
from angular-dialog-service.
Turns out I had failed to add 'dialogs.default-translations',
to my app module list.
from angular-dialog-service.
You beat me to it. I saw your email about the trouble but its such a pain to type out a message on a phone so I thought I'd wait to get to my office to message you back.
That was the first thing I thought of, that you hadn't added the translations to your application module. I had to do this because there were others complaining to me that they were already using angular.translate in their application elsewhere and that the automatic inclusion in the dialog service was overwriting their translations. I had to separate it out and make it mandatory to include the default-translations as part of using the dialog services.
I'm going to look into easing that a bit, perhaps have some kind of fall back if someone forgets to include the default module as you did.
Sorry about that Mark.
from angular-dialog-service.
Related Issues (20)
- Upgrade to angular-bootstrap ~1.0? HOT 6
- Call dialog from a bootstrap modal dialog - Position HOT 7
- the translation for chinese does not work. HOT 1
- Look into using the multi-transclusion feature in angular 1.5
- How to add buttons to error dialog?
- is it possible to change the url when a modal opens
- Remove bootstrap bower dependency
- More accessibility support HOT 5
- Disabling the X button for the dialogs HOT 2
- Error: $injector:modulerr Module Error HOT 5
- Confirm Dialog Doesn't work with ui.bootstrap v1.3.3 HOT 1
- how can i close dialog from service? HOT 1
- Dialog appearing behind bootstrap modal window. HOT 1
- Angular functions not work on modal HOT 1
- How to add class to modal-dialog?
- Angular bootstrap modal
- Setting default options for all dialogs HOT 1
- Support component param from angular bootstrap dialog HOT 4
- Font Awesome 5
- Options is not fitting in the input size
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-dialog-service.