Error with dialog after upgrading to Angular 1.3 about angular-dialog-service

[m-e-conroy]

Sorry for the wait I've been on vacation.

I'll look into it, but this may be a Angular-Translate problem with 1.3

[niemyjski]

Is there any updates on this? I'm also using angular 1.3

[niemyjski]

I'm getting the following error also when I dismiss a custom dialog:

TypeError: Cannot read property 'add' of undefined
at resolveElementClasses (http://localhost:9001/bower_components/angular-animate/angular-animate.js:480:22)
at http://localhost:9001/bower_components/angular-animate/angular-animate.js:1028:27
at http://localhost:9001/bower_components/angular-animate/angular-animate.js:469:22
at Scope.$digest (http://localhost:9001/bower_components/angular/angular.js:13324:36)
at Scope.$delegate.proto.$digest (:844:31)
at Scope.$apply (http://localhost:9001/bower_components/angular/angular.js:13540:24)
at Scope.$delegate.proto.$apply (:855:30)
at http://localhost:9001/bower_components/angular/angular.js:15267:36
at completeOutstandingRequest (http://localhost:9001/bower_components/angular/angular.js:4544:10)
at http://localhost:9001/bower_components/angular/angular.js:4851:7

[m-e-conroy]

I'm in the process of testing the service against 1.3

[niemyjski]

Can you please update the bower dependencies? I'd be more than happy to do a quick fork.

angular-dialog-service#5.2.1
│ ├── angular#1.3.0 incompatible with 1.2.x (1.2.27-build.519+sha.6eab8ab available, latest is 1.3.1-build.3430+sha.6502ab0)
│ ├── angular-bootstrap#0.11.2
│ ├─┬ angular-sanitize#1.2.26 (1.2.27-build.519+sha.6eab8ab available, latest is 1.3.1-build.3430+sha.6502ab0)
│ │ └── angular#1.3.0 incompatible with 1.2.26 (1.2.26 available, latest is 1.3.1-build.3430+sha.6502ab0)
│ ├── angular-translate#2.1.0 (latest is 2.4.1)
│ └── bootstrap#3.2.0 incompatible with 3.1.x (3.1.1 available, latest is 3.2.0)

[m-e-conroy]

If you want to do a fork, that would be much appreciated as I am extremely
busy today.

On Tue, Oct 14, 2014 at 11:54 AM, Blake Niemyjski [email protected]
wrote:

Can you please update the bower dependencies? I'd be more than happy to do
a quick fork.

angular-dialog-service#5.2.1
│ ├── angular#1.3.0 incompatible with 1.2.x (1.2.27-build.519+sha.6eab8ab
available, latest is 1.3.1-build.3430+sha.6502ab0)
│ ├── angular-bootstrap#0.11.2
│ ├─┬ angular-sanitize#1.2.26 (1.2.27-build.519+sha.6eab8ab available,
latest is 1.3.1-build.3430+sha.6502ab0)
│ │ └── angular#1.3.0 incompatible with 1.2.26 (1.2.26 available, latest
is 1.3.1-build.3430+sha.6502ab0)
│ ├── angular-translate#2.1.0 (latest is 2.4.1)
│ └── bootstrap#3.2.0 incompatible with 3.1.x (3.1.1 available, latest is
3.2.0)

—
Reply to this email directly or view it on GitHub
#56 (comment)
.

Michael E. Conroy
[email protected]

Blog: http://michaeleconroy.blogspot.com/
GitHub: https://github.com/m-e-conroy
LinkedIn Profile
https://www.linkedin.com/profile/view?id=260227&trk=nav_responsive_tab_profile

[niemyjski]

Done (#71). I believe everything should work.

semver version  #1.2.3
version range   #1.2
#~1.2.3
#^1.2.3
#>=1.2.3 <2.0

[niemyjski]

Seems like we need to update the minor versions that the package installs. It's still complaining about old versions on my end :(

[m-e-conroy]

Anything specifically? Angular UI?

On Wed, Oct 15, 2014 at 2:34 PM, Blake Niemyjski [email protected]
wrote:

Seems like we need to update the minor versions that the package installs.
It's still complaining about old versions on my end :(

—
Reply to this email directly or view it on GitHub
#56 (comment)
.

Michael E. Conroy
[email protected]

Blog: http://michaeleconroy.blogspot.com/
GitHub: https://github.com/m-e-conroy
LinkedIn Profile
https://www.linkedin.com/profile/view?id=260227&trk=nav_responsive_tab_profile

[niemyjski]

It won't resolve to the latest version of angular.sanitize or translate and it always asks me to pick the version of bootstrap I want even though I'm using the latest.

[m-e-conroy]

I think angular-boostrap is supposed to be angular-ui-boostrap

Although you said that wasn't your problem.

On Wed, Oct 15, 2014 at 2:37 PM, Blake Niemyjski [email protected]
wrote:

It won't resolve to the latest version of angular.sanitize or translate
and it always asks me to pick the version of bootstrap I want even though
I'm using the latest.

—
Reply to this email directly or view it on GitHub
#56 (comment)
.

Michael E. Conroy
[email protected]

Blog: http://michaeleconroy.blogspot.com/
GitHub: https://github.com/m-e-conroy
LinkedIn Profile
https://www.linkedin.com/profile/view?id=260227&trk=nav_responsive_tab_profile

[niemyjski]

Yeah, I think it should be too.

[m-e-conroy]

I updated the bower.json with a resolutions property and changed
angular-bootstrap to angular-ui-bootstrap. I doubled changed that
angular-translate and angular-sanitize were the proper names, I didn't find
anything wrong with them as they are.

On Wed, Oct 15, 2014 at 3:27 PM, Blake Niemyjski [email protected]
wrote:

Yeah, I think it should be too.

—
Reply to this email directly or view it on GitHub
#56 (comment)
.

Michael E. Conroy
[email protected]

Blog: http://michaeleconroy.blogspot.com/
GitHub: https://github.com/m-e-conroy
LinkedIn Profile
https://www.linkedin.com/profile/view?id=260227&trk=nav_responsive_tab_profile

[niemyjski]

I'm still pulling in the old version.. Can you please run this: http://bower.io/docs/api/#update

[m-e-conroy]

I think that only updates the package locally if there is a new version.

On Wed, Oct 15, 2014 at 4:08 PM, Blake Niemyjski [email protected]
wrote:

I'm still pulling in the old version.. Can you please run this:
http://bower.io/docs/api/#update

—
Reply to this email directly or view it on GitHub
#56 (comment)
.

Michael E. Conroy
[email protected]

Blog: http://michaeleconroy.blogspot.com/
GitHub: https://github.com/m-e-conroy
LinkedIn Profile
https://www.linkedin.com/profile/view?id=260227&trk=nav_responsive_tab_profile

[niemyjski]

Wait you are correct. For some reason I'm pulling down the old bower file that says version 5.2.0 instead of 5.2.2..

[niemyjski]

I even ran bower cache clean and then bower update angular-dialog-service -F

[m-e-conroy]

hmmm, it should have picked up the git tag for 5.2.2, that's how it states
it works. I'll have to put everything together and bump it to 5.2.3 and
see if that works.

On Wed, Oct 15, 2014 at 4:18 PM, Blake Niemyjski [email protected]
wrote:

I'm pulling down the old bower file that says version 5.2.0 instead of
5.2.2..

—
Reply to this email directly or view it on GitHub
#56 (comment)
.

Michael E. Conroy
[email protected]

Blog: http://michaeleconroy.blogspot.com/
GitHub: https://github.com/m-e-conroy
LinkedIn Profile
https://www.linkedin.com/profile/view?id=260227&trk=nav_responsive_tab_profile

[niemyjski]

Sounds good. Also looking at the latest bower file the versions are hard coded to 1.2.x and won't work with angular 1.3?

[m-e-conroy]

Yeah I haven't yet tested it with Angular 1.3, that's on my list.

Ok, i sync'd my local repo with the github repo and then bumped the version
to 5.2.3 with the new bower.json file. Hopefully everything gets picked up
soon and works out correctly.

On Wed, Oct 15, 2014 at 4:30 PM, Blake Niemyjski [email protected]
wrote:

Sounds good. Also looking at the latest bower file the versions are hard
coded to 1.2.x and won't work with angular 1.3?

—
Reply to this email directly or view it on GitHub
#56 (comment)
.

Michael E. Conroy
[email protected]

Blog: http://michaeleconroy.blogspot.com/
GitHub: https://github.com/m-e-conroy
LinkedIn Profile
https://www.linkedin.com/profile/view?id=260227&trk=nav_responsive_tab_profile

[m-e-conroy]

Oh by the way, I think there is a way you can override the Angular version
if you have a resolutions section in your application. In passing on Stack
Overflow I read about someone trying to accomplish this while trying to use
a version of jQuery 1.x when one of the modules bower was downloading had a
dependency of jQuery 2.x

On Wed, Oct 15, 2014 at 4:32 PM, Michael Conroy [email protected]
wrote:

Yeah I haven't yet tested it with Angular 1.3, that's on my list.

Ok, i sync'd my local repo with the github repo and then bumped the
version to 5.2.3 with the new bower.json file. Hopefully everything gets
picked up soon and works out correctly.

On Wed, Oct 15, 2014 at 4:30 PM, Blake Niemyjski <[email protected]

wrote:

Sounds good. Also looking at the latest bower file the versions are hard
coded to 1.2.x and won't work with angular 1.3?

—
Reply to this email directly or view it on GitHub
#56 (comment)
.

Michael E. Conroy
[email protected]

Blog: http://michaeleconroy.blogspot.com/
GitHub: https://github.com/m-e-conroy
LinkedIn Profile
https://www.linkedin.com/profile/view?id=260227&trk=nav_responsive_tab_profile

Michael E. Conroy
[email protected]

Blog: http://michaeleconroy.blogspot.com/
GitHub: https://github.com/m-e-conroy
LinkedIn Profile
https://www.linkedin.com/profile/view?id=260227&trk=nav_responsive_tab_profile

[niemyjski]

Thanks that worked! Please let me know when you update the dependencies to support the latest version and I'll update again as I'm currently seeing this.

I'll take a look into that.
─┬ angular-dialog-service#5.2.3
│ ├── angular#1.3.0 incompatible with ~1.2 (1.2.27-build.519+sha.6eab8ab available, latest is 1.3.1-build.3431+sha.ed85ec4)
│ ├─┬ angular-sanitize#1.2.26 (1.2.27-build.519+sha.6eab8ab available, latest is 1.3.1-build.3431+sha.ed85ec4)
│ │ └── angular#1.3.0 incompatible with 1.2.26 (1.2.26 available, latest is 1.3.1-build.3431+sha.ed85ec4)
│ ├── angular-translate#2.1.0 (latest is 2.4.1)
│ ├── angular-ui-bootstrap#0.11.2
│ └── bootstrap#3.2.0 incompatible with ~3.1 (3.1.1 available, latest is 3.2.0)

[m-e-conroy]

Great! I'm glad it worked.

I'll definitely give you a heads up when I get it tested and working on 1.3

On Wed, Oct 15, 2014 at 4:37 PM, Blake Niemyjski [email protected]
wrote:

Thanks that worked! Please let me know when you update the dependencies to
support the latest version and I'll update again as I'm currently seeing
this.

I'll take a look into that.
─┬ angular-dialog-service#5.2.3
│ ├── angular#1.3.0 incompatible with ~1.2 (1.2.27-build.519+sha.6eab8ab
available, latest is 1.3.1-build.3431+sha.ed85ec4)
│ ├─┬ angular-sanitize#1.2.26 (1.2.27-build.519+sha.6eab8ab available,
latest is 1.3.1-build.3431+sha.ed85ec4)
│ │ └── angular#1.3.0 incompatible with 1.2.26 (1.2.26 available, latest
is 1.3.1-build.3431+sha.ed85ec4)
│ ├── angular-translate#2.1.0 (latest is 2.4.1)
│ ├── angular-ui-bootstrap#0.11.2
│ └── bootstrap#3.2.0 incompatible with ~3.1 (3.1.1 available, latest is
3.2.0)

—
Reply to this email directly or view it on GitHub
#56 (comment)
.

Michael E. Conroy
[email protected]

Blog: http://michaeleconroy.blogspot.com/
GitHub: https://github.com/m-e-conroy
LinkedIn Profile
https://www.linkedin.com/profile/view?id=260227&trk=nav_responsive_tab_profile

[m-e-conroy]

5.2.x+ tested against Angular 1.3.0 and found to be working properly.

[niemyjski]

Yeah, I haven't found any other issues. Does this mean you'll be updating bower to target 1.3 :D?

[m-e-conroy]

Yes, i'll do that.

On Wed, Oct 29, 2014 at 11:41 AM, Blake Niemyjski [email protected]
wrote:

Yeah, I haven't found any other issues. Does this mean you'll be updating
bower to target 1.3 :D?

—
Reply to this email directly or view it on GitHub
#56 (comment)
.

Michael E. Conroy
[email protected]

Blog: http://michaeleconroy.blogspot.com/
GitHub: https://github.com/m-e-conroy
LinkedIn Profile
https://www.linkedin.com/profile/view?id=260227&trk=nav_responsive_tab_profile