Comments (6)
Isn't it resolve to free
here?
from lv_lib_png.
Isn't it resolve to
free
here?
lodepng.c uses lodepng_malloc() and lodepng_realloc() to allocate memory, which could be implemented independed from lodepng (especially if LODEPNG_COMPILE_ALLOCATORS not defined). And users which use this lib with RTOS can use OS allocators. You can also use lv_mem_ allocators, which can use heap/memory independend from system malloc(). And this is strange if lodepng use lv_mem_alloc() to allocate memory, but lv_png use system free() to free it. Potential memory leakage. It will be better to use lodepng_free() instead of free().
from lv_lib_png.
This problem may occur even if I will use latest branch of lvgl with lv_png as extra lib. For example, if I define in my project LODEPNG_NO_COMPILE_ALLOCATORS-macro and will create my own independent allocators (lodepng_malloc(), lodepng_realloc(), lodepng_free()) that won't use lv_mem_alloc()/realloc() but will use some memory region. In this case lodepng will use my allocators to allocate memory for png_data and dsc->img_data, but in lv_png this memory will not be freed because it uses lv_mem_free(), which has no information about where the memory was allocated. I think in this case also will be better to use lodepng_free() instead of lv_mem_free() (I mean lvgl-branch).
from lv_lib_png.
Got it.
Although, this lib is not required for v8 and v7 is already EOL, I'd be be happy to merge a PR if you send one.
from lv_lib_png.
I didn't test this changes - but it should work:
#29 - PR for release/v7 branch
#30 - PR for master branch
from lv_lib_png.
Both are merged, thanks!
from lv_lib_png.
Related Issues (20)
- Problem when using canvas on top of png HOT 4
- Some problems with imgbtn HOT 2
- bug with LODEPNG_COMPILE_ALLOCATORS option HOT 6
- how to enhance decoder's performance ? HOT 2
- PNG test on lv_port_stm32f429_disco HOT 9
- PNG photo 8 bitcolor someting wrong HOT 2
- memory allocation failed HOT 15
- png image not displayed properly HOT 3
- error: conflicting types for 'decoder_info' HOT 10
- invalid ADLER32 while drawing image HOT 13
- image with alpha channel is broken HOT 12
- 'LV_PNG_USE_LV_FILESYSTEM' is never used? HOT 9
- Png picture distortion HOT 5
- How to enable key color when displaying PNG HOT 4
- how to make the background of image button to be transparent? HOT 2
- can't display the png img in vs2019 simulator HOT 2
- Lv_lib_png showing white rectangle HOT 11
- Does APNG support? HOT 4
- Load PNG from variable HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lv_lib_png.