Comments (6)
I suggest doing this in the libuv style(reporting the status to Lua but convert it to error message string first)
from luv.
sounds good.
from luv.
But between the three style you said in the issue I opened, I prefer the second one.
from luv.
I would have thought you liked the first one. For the connect
event, for example, there is no data, but there might be an error. So to do assert style I would have to create a truthy result like true
for the non-error case. Success would be (true)
and error would be (nil, "error message")
. But with the first style it would be (nil)
for success and ("error message")
for error.
from luv.
I thought the 2nd style is just what other Lua libraries do for example, LuaSocket's connect returns nil plus error or true. But now I thought assert is not always used because the callbacks are invoked by uv.run and assert will cause error at the main loop so the service will down. It is convient for the return values to use the assert style but not callbacks. So I now changed to prefer the 1st style. Sorry to bother you.
from luv.
The current style is as follows:
Any libuv function that returns an int status is assertable on the lua side.
Any callback with status in it will inject an error at the front of the callback list.
callbacks related to handles do have the handle before the err as self. So for example, timers look like:
uv.timer_start(uv.new_timer(), 1000, 0, function (timer)
end)
And TCP Connect looks like:
local req = uv.tcp_connect(uv.new_tcp(), "localhost", 1337, function (handle, err)
end)
from luv.
Related Issues (20)
- fs_scandir_next() sometimes returns name but no type HOT 6
- track issues in neovim related with luv HOT 4
- CI failing for LuaJIT v2.1 branch
- process creation segfault HOT 2
- How to pass command line string to uv.spawn? HOT 4
- Do I have to use `uv.run()` to wait async reading file with `fs_read` API? HOT 2
- Question: Is `shutdown` and `close` (use new_pipe with spawn) sync or async? HOT 1
- Question: the arrival order of uv.spawn `on_exit` and `data == nil` in `read_start` callback on Windows 10? HOT 2
- Why udp_recv_start callback call twice? HOT 2
- `tty normal` normal tests fails for me on Fedora mockbuild HOT 4
- Error loading module luv HOT 3
- Unable to send handles with uv_write2
- UBSan is detecting problems but not failing the CI
- Importance of case for signal names (and other names) HOT 1
- luv_handle_gc segfault (from neovim) HOT 8
- Flaky UDP test in CI HOT 3
- A test failure while building luv in mock for Amazon Linux 2023
- Lua 5.4.7 update HOT 4
- callbacks for signal_start and signal_start_oneshot should receive a number HOT 9
- atexit() is probably not a good way to clean up Lua VM HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from luv.