Comments (4)
Not sure I understand.
from luv.
In the dns.c:on_addrinfo, remove these code:
if (ntohs(port)) {
lua_pushinteger(L, ntohs(port));
lua_setfield(L, -2, "port");
}
if (curr->ai_socktype == SOCK_STREAM) {
lua_pushstring(L, "STREAM");
lua_setfield(L, -2, "socktype");
}
else if (curr->ai_socktype == SOCK_DGRAM) {
lua_pushstring(L, "DGRAM");
lua_setfield(L, -2, "socktype");
}
switch (curr->ai_protocol) {
...
default:
lua_pushstring(L, NULL);
}
lua_setfield(L, -2, "protocol");
Because this is just the arg for querying and DNS servers doesn't return this at all. DNS server just record the IP address but it doesn't care which port and socket type the client will use. It is defined in addrinfo struct but not used by getaddrinfo. And if you use DNS the protocol must be INET or INET6 because DNS belongs to IP but INET or INET6 can be determined with the family field.
So these code will cause misunderstanding.
By the way, I think libuv has just one API for name resolving, so it is not necessary to create a sperated dns.c file.
from luv.
@imzyxwvu Please review the PR to make sure I understand what you mean.
I know there is only one dns function in libuv, but I put it in it's own file because it's a lot of code. Even after this patch is applied it's over 200 lines while parts like pipe are well under 100 lines.
from luv.
I still thought some fields are used for C socket API and useless for Lua. But in some cases those may be required, so this should be discussed in the future.
from luv.
Related Issues (20)
- `cpu_info` binding might not handle `model` correctly HOT 2
- Release 1.45.0 checklist. HOT 1
- Add `fs_access` test(s)
- request bind v1.46.0 new features
- fs_scandir_next() sometimes returns name but no type HOT 6
- track issues in neovim related with luv HOT 4
- CI failing for LuaJIT v2.1 branch
- process creation segfault HOT 2
- How to pass command line string to uv.spawn? HOT 4
- Do I have to use `uv.run()` to wait async reading file with `fs_read` API? HOT 2
- Question: Is `shutdown` and `close` (use new_pipe with spawn) sync or async? HOT 1
- Question: the arrival order of uv.spawn `on_exit` and `data == nil` in `read_start` callback on Windows 10? HOT 2
- Why udp_recv_start callback call twice? HOT 2
- `tty normal` normal tests fails for me on Fedora mockbuild HOT 4
- Error loading module luv HOT 3
- Unable to send handles with uv_write2
- UBSan is detecting problems but not failing the CI
- Importance of case for signal names (and other names) HOT 1
- luv_handle_gc segfault (from neovim) HOT 8
- Flaky UDP test in CI HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from luv.