builtin.open_in_split opens first file in list and not selected. about nnn.nvim

[luukvbaal]

It uses the non-recursive :h tnoremap instead of the :h tmap command. Meaning that it will use internal vim mappings rather than potential user-defined mappings. I should have included that from the start.

[luukvbaal]

Hmm, I cannot reproduce this. It should open the hovered file or the active selection if it exists.

[Svenum]

Maybe the issue is somewhere else in my config:
https://github.com/Svenum/nvim-config

[luukvbaal]

Can you make a screen recording of your problem?

[Svenum]

Peek.2023-02-05.17-30.mp4

[luukvbaal]

I have no idea what could cause this sorry. If it is splitting the window, it must mean it is executing the mapping. Could you try adding a debug print statement?

+++ b/lua/nnn.lua
@@ -422,6 +422,7 @@ end
 local function open_in(files, command)
        for _, file in ipairs(files) do
                c(command.." "..file)
+               vim.pretty_print(command.." "..file)
        end
 end

[Svenum]

I am added it like this in my "~/.config/nvim/autoload/plugged/nnn.nvim/lua/nnn.lua":

Where should I see the debug-code?

[luukvbaal]

It should show up in :messages after using a mapping.

[luukvbaal]

But you should just add the single pretty_print() line to the existing open_in() function, not define a new function at the top of the file:

nnn.nvim/lua/nnn.lua

Lines 421 to 426 in 440ddfd

	-- Builtin mapping functions
	local function open_in(files, command)
	for _, file in ipairs(files) do
	c(command.." "..file)
	end
	end

[Svenum]

I got the output:
"vsplit /home/user/test/nnn-test/cloud.txt"
(vsplit first item in the list and not hovered)

[luukvbaal]

I don't understand how it could happen, there must be something interfering. Can you try this in NnnExplorer instead? That way you should be able to see what actually happens in the terminal window as it stays open.

[Svenum]

In NnnExplorer it is switching to the first item and then opening it in the new window.

[Svenum]

If Try it a second time in NnnExplorer it opens as it should be. Until i reopen it.

[luukvbaal]

Is it really switching to the first item in a directory with more than two files? Or perhaps just the file above it? The mapping must be feeding either a g, or k key somehow.

[luukvbaal]

Can you check if this fixes the issue?

+++ b/lua/nnn.lua
@@ -221,14 +221,15 @@ local function buffer_setup()
                a.nvim_buf_set_option(0, opt, val)
        end

+       local opts = { noremap = true }
        for i, mapping in ipairs(cfg.mappings) do
-               a.nvim_buf_set_keymap(0, "t", mapping[1], "<C-\\><C-n><cmd>lua require('nnn').handle_mapping("..i..")<CR>", {})
+               a.nvim_buf_set_keymap(0, "t", mapping[1], "<C-\\><C-n><cmd>lua require('nnn').handle_mapping("..i..")<CR>", opts)
        end

-       a.nvim_buf_set_keymap(0, "t", cfg.windownav.left, "<C-\\><C-n><C-w>h", {})
-       a.nvim_buf_set_keymap(0, "t", cfg.windownav.right, "<C-\\><C-n><C-w>l", {})
-       a.nvim_buf_set_keymap(0, "t", cfg.windownav.next, "<C-\\><C-n><C-w>w", {})
-       a.nvim_buf_set_keymap(0, "t", cfg.windownav.prev, "<C-\\><C-n><C-w>W", {})
+       a.nvim_buf_set_keymap(0, "t", cfg.windownav.left, "<C-\\><C-n><C-w>h", opts)
+       a.nvim_buf_set_keymap(0, "t", cfg.windownav.right, "<C-\\><C-n><C-w>l", opts)
+       a.nvim_buf_set_keymap(0, "t", cfg.windownav.next, "<C-\\><C-n><C-w>w", opts)
+       a.nvim_buf_set_keymap(0, "t", cfg.windownav.prev, "<C-\\><C-n><C-w>W", opts)
 end

  -- Restore buffer to previous state

[Svenum]

It resolved it :)

[Svenum]

What does this change do?