Coder Social home page Coder Social logo

Comments (14)

thomascft avatar thomascft commented on May 27, 2024 2

which playlist needs to be embeded.

I assume the objective is to embed videos from the chris@machine for things such as this. The idea is to give new users a video introduction to different nvim concepts. A good place to start may be to embed all of the neovim from scratch videos in their respective locations.

from lunarvim.org.

jatinmark avatar jatinmark commented on May 27, 2024 1

I added two videos and make a pull request . please check it and give me feedback

from lunarvim.org.

jatinmark avatar jatinmark commented on May 27, 2024 1

@mhmdali102 i am working on this.

from lunarvim.org.

jatinmark avatar jatinmark commented on May 27, 2024 1

@mhmdali102 you fixed the issue . Now i am thinking to embed more videos .

from lunarvim.org.

jatinmark avatar jatinmark commented on May 27, 2024 1

@mhmdali102 & @vonPB can you review it please.

from lunarvim.org.

jatinmark avatar jatinmark commented on May 27, 2024 1

@mhmdali102 thank you !

from lunarvim.org.

jatinmark avatar jatinmark commented on May 27, 2024

I would like to work on this. Can you please assign this to me?

from lunarvim.org.

jatinmark avatar jatinmark commented on May 27, 2024

can you please elaborate it .

from lunarvim.org.

jatinmark avatar jatinmark commented on May 27, 2024

which playlist needs to be embeded.

from lunarvim.org.

MAHcodes avatar MAHcodes commented on May 27, 2024

hey @jatinmark,
embedded youtube video has fixed width, so it's causing overflow on small screens < video width,
you can see code example for the fix in src/compontents/YouTube/styles.module.css as a reference.
screenshot showing the issue on Galaxy S7 Edge
photo_2022-10-11_05-55-21 (2)

from lunarvim.org.

jatinmark avatar jatinmark commented on May 27, 2024

@mhmdali102 i want to ask that my previous PR is accepted or not , if accepted then i have make an another PR to solve this issue ?

from lunarvim.org.

MAHcodes avatar MAHcodes commented on May 27, 2024

@jatinmark #243 was merged into master, you need to open another PR to fix this issue.

from lunarvim.org.

MAHcodes avatar MAHcodes commented on May 27, 2024

@jatinmark fixed it here

from lunarvim.org.

MAHcodes avatar MAHcodes commented on May 27, 2024

looks good @jatinmark! I merged ur pr, github closed this issue automatically.

from lunarvim.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.