Bug in luaL_setfuncs about md5

[tomasguisasola]

Hi Philipp

Thanks.  I've just corrected it.  I am also contributing this

correction to Compat-5.2 (I think yours have a bug also: lua_settable(L,
-3), because lua_pushccloseure pops the upvalues from the stack.

Thanks,
    Tomás

On Fri, 20 Sep 2013, Philipp Janda wrote:

luaL_setfuncs in src/compat-5.2.c doesn't work if nups > 0. See keplerproject/lua-compat-5.2@adf9db4a5. Currently you don't need upvalues for this module, so this is not a pressing issue ...

---

Reply to this email directly or view it on GitHub:
#4

[siffiejoe]

I believe my version was correct (and my tests agree with me):
The initial layout when luaL_setfuncs(L, l, 2) is called:
table|up1|up2
then after lua_pushstring:
table|up1|up2|name
then after the loop pushing all upvalues:
table|up1|up2|name|up1|up2
then after the lua_pushcclosure call:
table|up1|up2|name|closure
So for the lua_settable index we have to skip the name, the closure, and the upvalues to get the table ...
The table is at -5 which is -(nups+3)!

[tomasguisasola]

Hi Philipp

Sure, you were right from the begining.  Please forgive my

stubbornness.

Regards,
    Tomás

On Sat, 21 Sep 2013, Philipp Janda wrote:

I believe my version was correct (and my tests agree with me):
The initial layout when luaL_setfuncs(L, l, 2) is called:
table|up1|up2
then after lua_pushstring:
table|up1|up2|name
then after the loop pushing all upvalues:
table|up1|up2|name|up1|up2
then after the lua_pushcclosure call:
table|up1|up2|name|closure
So for the lua_settable index we have to skip the name, the closure, and the upvalues to get the table ...
The table is at -5 which is -(nups+3)!

---

Reply to this email directly or view it on GitHub:
#4 (comment)

[siffiejoe]

No problem :-)
Btw., the lua_settable(L, -(nup + 3)) was your code to begin with ...

[tomasguisasola]

Hi Philipp

On Mon, 23 Sep 2013, Philipp Janda wrote:

No problem :-)
Thanks,

Btw., the lua_settable(L, -(nup + 3)) was your code to begin with ...
In fact, it was a careless translation of the original
implementation of luaL_setfuncs from Lua 5.2.0 code. It just happened
to be right by accident :-)

Regards,
    Tomás