Comments (2)
Hi!
Ok, here are the reasons why nothing has happened yet:
We already have an implementation of debug.traceback
in compat53/init.lua
. This version incorporates the stack trace of the internal coroutine used by our yieldable (x)pcall
implementations. As far as I can tell it also does something when the message is nil
.
If we add a new implementation of debug.traceback
to compat53/module.lua
, we should probably adjust the current version in compat53/init.lua
as well to make them compatible. Since I haven't figured out a way to share common code between those two files (but I have been wrong on this before), this would involve a lot of extra code and work to fix basically a very rare and minor issue: the nil
as message problem. The differences in the stack traces don't really count IMHO, because all our replacement functions cause stack traces (and sometimes error messages) to be different from a genuine Lua 5.3 session (although the current debug.traceback
implementation goes to great lengths (unnecessarily so, IMHO) to reformat stack traces).
So I'm currently inclined to revisit this issue later when the stack level problem in current Lua 5.3 has been fixed by the Lua authors.
Suggestions/opinions?
from lua-compat-5.3.
Yeah Roberto said that he'd actually fix 5.3's tracebacks in a point release; so the tracebacks themselves can probably be safely ignored.
So it can just be an issue of making debug.traceback
nil
safe.
from lua-compat-5.3.
Related Issues (20)
- Failure with luajit 2.1 HOT 4
- Compiling with Lua 5.3 fails HOT 1
- lua_pushstring should return pushed string
- Macro safety HOT 1
- Add lua_resume
- luaL_Stream
- LUAERRGCM missing HOT 1
- luaL_loadbufferx HOT 1
- Problems with detection of strerror_r HOT 3
- lua_getuservalue should return type HOT 2
- lua_tointegerx accepts non-integers HOT 5
- Build fail with x86_64-w64-mingw32-gcc on MacOS HOT 1
- luaossl installation fails on alpine docker image HOT 8
- src/compat-5.3.c:59:9: error: implicit declaration of function 'strerror_r' [-Werror=implicit-function-declaration]
- src/compat-5.3.c:451:42: error: initializer element is not computable at load time [-Werror=pedantic] HOT 2
- luaL_typeerror HOT 4
- How to compile on windows HOT 4
- Lua 5.4 HOT 11
- Tests fail on 32bit systems HOT 18
- table.maxn HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lua-compat-5.3.