Coder Social home page Coder Social logo

Comments (8)

lukehaas avatar lukehaas commented on July 22, 2024

Thanks, I've just pushed a fix to jquery.scrollify.js that should resolve this.

from scrollify.

noinstance avatar noinstance commented on July 22, 2024

Same problem that I had. Your fix didn't work for me. See my pull request.

from scrollify.

zakgreene avatar zakgreene commented on July 22, 2024

Hi, I was having the same issue, tried your fix and although it removed the JS error, it can't seem to scroll. The URL hash also changes to /#[object Object]. Tried using .move() to no avail.

from scrollify.

noinstance avatar noinstance commented on July 22, 2024

If you're using the minified version, don't, I didn't update it. The non minified version works for me. I'm calling $.scrollify({ params }) if the window width is bigger than a certain size. If it is resized down, i call $.scrollify.destroy() and $.scrollify({ params }) again if resized up.

from scrollify.

zakgreene avatar zakgreene commented on July 22, 2024

I'm using the non-minified verison. When I recreate the $.scrollify instance after destroying it, I sometimes get an error Cannot read property 'height' of undefined. This only happens if I've scrolled down a bit when recreating the instance. In every case, the URL becomes /#[object Object].

from scrollify.

noinstance avatar noinstance commented on July 22, 2024

Maybe it's a different problem? I can't duplicate that. My urls look nice
too.

On Mon, Sep 7, 2015 at 7:23 PM, Zak Greene [email protected] wrote:

I'm using the non-minified verison. When I recreate the $.scrollify
instance after destroying it, I sometimes get an error Cannot read
property 'height' of undefined. This only happens if I've scrolled down a
bit when recreating the instance. In every case, the URL becomes /#[object
Object].


Reply to this email directly or view it on GitHub
#36 (comment).

from scrollify.

lukehaas avatar lukehaas commented on July 22, 2024

I realised what was wrong with the update I pushed. I've pushed another update that resolves both your problems.

from scrollify.

zakgreene avatar zakgreene commented on July 22, 2024

This works great now, thank you @lukehaas! I'm still sometimes getting the error Cannot read property 'height' of undefined sometimes when I destroy(), but it doesn't affect anything on the site.

from scrollify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.