Comments (4)
For Ember users who may have the same problem, my workaround is to use CollectionView
to generate the ul
: http://jsbin.com/lemahu/4/edit
from html5sortable.
Wouldn't it be sensible to do it this way, because if you want to add an item to the list the actual position it should be appended to is the index you get.
I don't know ember, and the <script>
tags seem a little weird to me, but if you have a list like the following I would think an index should include the disabled item, so when you add a ne item with js (like moving to a connected list) it gets the correct position.
<ul>
<li class="disabled">...<li>
<li>...</li>
<li>...</li>
<li>...</li>
</ul>
from html5sortable.
@lukasoppermann I agree that it's weird ember generates such script tags and they're actually breaking the HTML structure. Nevertheless, since the items
option is for specifying which items inside the element should be sortable, I naturally think that the index is referring to position among the sortable items but in fact it is the position among the item's sibling elements. If this is the original design, I think it should be stated in the documentation.
from html5sortable.
@lacek I see what you mean, as I thought the same for a moment, but consider you want to add an item into your list at the visual index 2. If you would use index: 2
it would be added before the visible items, so it actually makes sense to calculate the "real index".
Do you have a use-case where it is necessary to have the index of only the items? I guess you could always send a PR adding another value to the event like items-index
or maybe something with a better name.
I do also agree on a need to document this behaviour so maybe you want to send a separate PR for this?
from html5sortable.
Related Issues (20)
- Rename index.ts to to getIndex.ts HOT 1
- The dependecy 'rollup-plugin-typescript' is deprecated HOT 9
- Replace Travis with github action
- ability for 'acceptFrom' to accept a function as an argument HOT 5
- There is a serialize but no deserialize HOT 1
- Sorting, cursor and drop area HOT 1
- Strange behavior of 'maxItems' property HOT 2
- form inputs mouse cursor positioning issue in Firefox HOT 1
- When drop is finished all items below placeholder flicker. HOT 2
- abort sortleave event HOT 8
- maxItems setting not working correctly HOT 2
- Is there a way to access dataTransfer from sortstart event?
- Brave browser not supported in 0.13.3 version HOT 2
- changing style of dragged element HOT 1
- Drag element to anywehere in sortable HOT 3
- Unsortable item can be sorted in some cases HOT 3
- Plz how to cancel the defalut transparent style of dragging Image? HOT 1
- get pageX and pageY HOT 1
- Framework adapter for AngularJS
- Import fails with Astro Build HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from html5sortable.