Comments (11)
Sorry I missed this. I will loom into the Pr by @JackHowa to merge it
from design-tokens.
here's the updated pr #300. I had to break out some utils so they were easier to test
from design-tokens.
I'm seeing this as well
from design-tokens.
Yes, it would be really nice if that could be fixed.
from design-tokens.
Any updates here?
from design-tokens.
I can also reproduce this. This sadly makes the plugin unusable :/
from design-tokens.
Hey, I looked into it but it is not as easy as you made it seem. 🤣
@JackHowa can you please just add the needed test to the PR you made? #289
Only the test please. Happy to look into the other PR you closed as a separate one. But I would love the PR to stay as it is and just add a test so I don't have to re-review and can merge it as soon as the test is there. 🙏
from design-tokens.
here's the tests! https://github.com/lukasoppermann/design-tokens/pull/300/files#diff-e837ef5c10534f796d3fb7ce69273c9fc247852124c1ea52c0eed956756c9281
from design-tokens.
ah I didn't make that pr linked #289 but I can see if I can make a clean pr for ya
from design-tokens.
Okay, I merged and released this now. Can you please test if this fixes it?
from design-tokens.
Okay, I merged and released this now. Can you please test if this fixes it?
Yep works for me!
from design-tokens.
Related Issues (20)
- Bug with Variables export HOT 2
- Variable aliases do not take into account token prefix settings HOT 1
- Double neasted mode name in json output
- Variable modes are not added if the collection name is uppercase in figma.
- Aliases to aliases cause wrong category to be set
- json output: missing modes in referenced tokens HOT 3
- Plugin not working HOT 5
- Send design tokens to URL option does not work : Error 422
- Variables export not working. HOT 7
- Gradient angle not correct HOT 1
- Cannnot send design token to github HOT 5
- Tokens as a source for truth rather than figma? HOT 1
- Content-Security-Policy is blocking our company url HOT 1
- prefix exclusions should work with variables too, not just styles HOT 1
- Font weights are not extracted from custom font HOT 1
- Feature Request: Push File To Gitlab
- Mode name are duplicated in referenced values HOT 22
- Last component of variable names are always exported in lowercased
- Question of your point of view about design tokens JSON as source of truth HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from design-tokens.