Coder Social home page Coder Social logo

Comments (11)

lukasoppermann avatar lukasoppermann commented on September 21, 2024 2

Sorry I missed this. I will loom into the Pr by @JackHowa to merge it

from design-tokens.

JackHowa avatar JackHowa commented on September 21, 2024 1

here's the updated pr #300. I had to break out some utils so they were easier to test

from design-tokens.

JackHowa avatar JackHowa commented on September 21, 2024

I'm seeing this as well

from design-tokens.

Franjoo avatar Franjoo commented on September 21, 2024

Yes, it would be really nice if that could be fixed.

from design-tokens.

Franjoo avatar Franjoo commented on September 21, 2024

Any updates here?

from design-tokens.

JulianBissekkou avatar JulianBissekkou commented on September 21, 2024

I can also reproduce this. This sadly makes the plugin unusable :/

from design-tokens.

lukasoppermann avatar lukasoppermann commented on September 21, 2024

Hey, I looked into it but it is not as easy as you made it seem. 🤣

@JackHowa can you please just add the needed test to the PR you made? #289

Only the test please. Happy to look into the other PR you closed as a separate one. But I would love the PR to stay as it is and just add a test so I don't have to re-review and can merge it as soon as the test is there. 🙏

from design-tokens.

JackHowa avatar JackHowa commented on September 21, 2024

here's the tests! https://github.com/lukasoppermann/design-tokens/pull/300/files#diff-e837ef5c10534f796d3fb7ce69273c9fc247852124c1ea52c0eed956756c9281

from design-tokens.

JackHowa avatar JackHowa commented on September 21, 2024

ah I didn't make that pr linked #289 but I can see if I can make a clean pr for ya

from design-tokens.

lukasoppermann avatar lukasoppermann commented on September 21, 2024

Okay, I merged and released this now. Can you please test if this fixes it?

from design-tokens.

JackHowa avatar JackHowa commented on September 21, 2024

Okay, I merged and released this now. Can you please test if this fixes it?

Yep works for me!

from design-tokens.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.