Coder Social home page Coder Social logo

Comments (3)

LukasJoswiak avatar LukasJoswiak commented on July 22, 2024 5

Hi, thanks for opening an issue. I've been thinking about this for a while, but I'm not sure I'm convinced of how necessary it is. This seems like (as you mentioned) what forking is meant to do. Forks can be kept up to date with the upstream repository as well. A more lightweight alternative to forking is to just modify the CSS in the theme after adding it as a submodule.

I did look into implementing this. Currently, the CSS files in assets/css/ are combined into a single file and minified. The goal is to keep the number of network requests down (it can be argued whether this is a worthwhile goal). Anyway, it appears that resources.Get can only read files from the assets folder within the theme folder and not from within the user's website folder. This means it would be necessary to make extra network requests for each user defined stylesheet. Since I'm not yet convinced how necessary this feature is in the first place I'm hesitant to go ahead with implementing it. I'm happy to keep discussion open though.

from etch.

burtonr avatar burtonr commented on July 22, 2024 2

I agree, this would be a great feature. 👍

from etch.

LukasJoswiak avatar LukasJoswiak commented on July 22, 2024 2

It's been a while and I still think forking is the way to go for changes, so I'm going to close this issue.

from etch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.