Comments (5)
Plus, how should it be called?
accessorsNamed
- 👎 the default → shorter one should be the named variant
accessors_
- 👎 undescriptive
- 👎 the default → shorter one should be the named variant
- 👍 mirrors the package's naming scheme (even though I don't like it)
- a silent switch of implementation for
accessors
and the addition ofaccessorsUnnamed
- 👎 would be a breaking change (not in terms of package version)?
- 👍 the default → shorter one is the named variant
from elm-review-missing-record-field-lens.
So my thought is these are part of the same package / namespace because they're all "Optics" I couldn't think of how to merge the two under the same namespace but if you have any ideas that's my ideal. Otherwise, it's just a separate rule that gets added to the list of rules that I run on a watcher 🤷♂️
from elm-review-missing-record-field-lens.
Have a generator like this lying around? → PR
Isn't that what I PR'd before? not sure what you mean?
from elm-review-missing-record-field-lens.
It's about RecordFieldLensGenerator
s as the title suggests: the current field accessor is unnamed and annotated with Relation
s.
My question was whether changing the implementation under the hood is fine and whether an unnamed version should be added (or rather, how that one should be called)
from elm-review-missing-record-field-lens.
Fixed by
- changing the
accessors
implementation toerlandsona/elm-accessors
- adding
accessorsBQuiquet
from elm-review-missing-record-field-lens.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elm-review-missing-record-field-lens.