Continue Warp Migration about lucid

[imclint21]

@CephalonRho

Now we have warp::serve(routes).bind() is it possible to replace with bind_with_graceful_shutdown?

Cheers

[shuni64]

Sure, there shouldn't be a problem just replacing it with bind_with_graceful_shutdown and adding a shutdown channel. I'm not sure how we would trigger it though, to me it seems like it's is meant to give the program the ability to shut down only the warp server and explicitly clean up resources afterwards, so this would only be useful when adding persistence later.

Lucid seems to shut down gracefully enough right now, I don't get any error when stopping it with SIGINT on Linux.

[imclint21]

Oh for the error I don't have too, only when it's in debug, but it's not really important.

If we can use bind_with_graceful_shutdown I think it's better

[imclint21]

For the explicit cleanup, it's interesting, I will think about that