Coder Social home page Coder Social logo

Comments (2)

lucacasonato avatar lucacasonato commented on May 17, 2024

Why does the externals option not cover this? Can we re-use that option? I'd be happy to review & merge a PR.

from esbuild_deno_loader.

mfulton26 avatar mfulton26 commented on May 17, 2024

I ran into this issue today. Here's a small demonstration:

main.tsx

import React from "https://esm.sh/[email protected]?dev";

export default function App() {
  return <h1>Hello, world!</h1>;
}

demo.ts

import * as esbuild from "https://deno.land/x/[email protected]/mod.js";
import { denoPlugin } from "https://deno.land/x/[email protected]/mod.ts";

const result = await esbuild.build({
  plugins: [
    // @ts-expect-error types don't agree for some unrelated reason
    denoPlugin(),
  ],
  entryPoints: ["main.tsx"],
  outfile: "./dist/main.esm.js",
  bundle: true,
  format: "esm",
  external: ["https://deno.land/*"],
});

console.log(result.outputFiles);

esbuild.stop();

dist/main.esm.js should result in being a small file with an import statement for React but instead it bundles React.

from esbuild_deno_loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.