Comments (9)
Fixed it. It would be nice to make a new build. It's Android specific. daniel-luberda@8d506a4
from ffimageloading.
I don't understand the fix. Could you explain it before I merge it?
Once explained it's fine for me to make a new Nuget packag. Btw shouldn't we reference the newer Xamarin Forms version since you removed the "hack"?
from ffimageloading.
Of course. Invalidate is an Android method. If invalidate() gets called it tells the system that the current view has changed and it should be redrawn as soon as possible. Original Image renderer had an Invalidate override that skips Invalidate operation once after setting ImageSource. That was the cause why images didn't always reload when FAST scrolling. I just removed override and that's all.
About the hack that was removed:
I'm still thinking if we should merge it know, a lot of people still uses Xamarin.Forms 1.4.4 (I sent you a mail about it). The hack doesn't collide with anything. On the other side, FFImageLoading auto-cancels cache request when another one arrives. What do you think?
from ffimageloading.
Thanks Daniel it's much clearer now.
I think it would be better to remove the hack and change nuspec. As you said the lib automatically auto cancels previous requests so it's quite safe to do so.
from ffimageloading.
Ok, if canceling a lot of requests is fine, we could merge it. :) But don't change dependencies to XF >-1.5, 1.4 is fine too (it'll just cancel requests)
from ffimageloading.
Fine for me!
from ffimageloading.
Ok :)
from ffimageloading.
New nuget pushed: https://www.nuget.org/packages/Xamarin.FFImageLoading.Forms/
Could you give it a try?
from ffimageloading.
Working good. Can be closed :)
from ffimageloading.
Related Issues (20)
- Check if Image Server side has changed from Cached version
- [Bug]In Xamarin.Forms (Android) throws System.ArgumentException in ImageService.SetTaskForTarget (FFImageLoading.Work.IImageLoaderTask currentTask).
- Support for image width/height query in the URL
- Some SVG images are displaying and some are not HOT 3
- CacheKeyFactory used in a CollectionView causes incorrect images to load.
- ReplaceStringMap Question
- Images from URL don't show at all on iOS in Xamarin Forms 5 app HOT 1
- For MAUI see here.... HOT 3
- Image Adjustments in Xamarin
- [ISSUE] [Android] GIF animation weird behavior
- App crashes after calling ImageService.SetTaskForTarget HOT 1
- Guid inside URL is changed
- .Net 6 support HOT 4
- Incomplete downloaded image is cached.
- Images disappear on Android after pressing the (hardware) Back button HOT 1
- .Net 8 support HOT 2
- RotateTransformation does not rotate images on iOS 17 HOT 1
- Image won't load in Maui Windows app
- Inquiry about Data Collection
- On windows image download fails randomly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ffimageloading.