Xamarin.Forms - Images get mixed after a lot of requests (cell reusing) about ffimageloading

[daniel-luberda]

Fixed it. It would be nice to make a new build. It's Android specific. daniel-luberda@8d506a4

[molinch]

I don't understand the fix. Could you explain it before I merge it?

Once explained it's fine for me to make a new Nuget packag. Btw shouldn't we reference the newer Xamarin Forms version since you removed the "hack"?

[daniel-luberda]

Of course. Invalidate is an Android method. If invalidate() gets called it tells the system that the current view has changed and it should be redrawn as soon as possible. Original Image renderer had an Invalidate override that skips Invalidate operation once after setting ImageSource. That was the cause why images didn't always reload when FAST scrolling. I just removed override and that's all.

About the hack that was removed:
I'm still thinking if we should merge it know, a lot of people still uses Xamarin.Forms 1.4.4 (I sent you a mail about it). The hack doesn't collide with anything. On the other side, FFImageLoading auto-cancels cache request when another one arrives. What do you think?

[molinch]

Thanks Daniel it's much clearer now.
I think it would be better to remove the hack and change nuspec. As you said the lib automatically auto cancels previous requests so it's quite safe to do so.

[daniel-luberda]

Ok, if canceling a lot of requests is fine, we could merge it. :) But don't change dependencies to XF >-1.5, 1.4 is fine too (it'll just cancel requests)

[molinch]

Fine for me!

[daniel-luberda]

Ok :)

[molinch]

New nuget pushed: https://www.nuget.org/packages/Xamarin.FFImageLoading.Forms/
Could you give it a try?

[daniel-luberda]

Working good. Can be closed :)