Images Do Not Load about ffimageloading

[molinch]

Wow that is ultra weird! I looked at the fix you submitted in Acr UserDialogs and it's really random things that fixes this...
Should be fixed asap

Also note that in the sample app... Forms Example.... You have to go into "Release" build config for this error to happen. Seems ok in "Debug" , and has to be tested on a actual device, works fine in simulator.

So Recap...
Release Mode
Actual device not simulator
Advanced iOS build settings ARMv7 + ARM64
...
Then you get this while testing in the Forms sample app in the repository....

[molinch]

Huge thanks for debugging this @HIGHPlains 👍

[molinch]

Btw I tested FFImageLoading with Arm7+64, in release mode, on a real 64b device. It works fine.
So I guess it comes from the Xamarin Forms wrapper.

Ya i spent a little bit of time looking for it, but couldn't find it. I know that the previous stable build didn't have this bug so it's something new within those commits.

What was weird is that i matched up my Debug and Release configurations to be identical, and the issue still only occurs when in Release mode. But the main problem is that with the latest build release versions are worthless making a App Store push now impossible without reverting to an old version.

[molinch]

I'm trying all options.... A few more things:

• ARMv7: OK
• ARM64: OK
• ARMv7+ARM64: KO... WHAT THE FUCK

lol RIGHT! Freaking mind boggling.

[daniel-luberda]

Ok, if it's with forms I'll check on this. REALLY strange bug though. Maybe it's something with project options? "Compilation Turned on optimizations" <- it's what comes into my mind (it wasn't checked in previous builds).

I tried every combination of optimizations in all projects... Still couldn't get it to work.

[daniel-luberda]

It could be also a bug with Xamarin.Forms ViewRenderer (we switched from Image class to View class). I could make a commit with "the old way". Could you test it?

sure

[molinch]

YAY: https://bugzilla.xamarin.com/show_bug.cgi?id=31076
I am 100% sure we hit this one...

[daniel-luberda]

Ok... That's quite reasonable explanation. It could be a linking problem. It's easy to fix, just include this in AppDelegate:

        public override bool FinishedLaunching(UIApplication app, NSDictionary options)
        {
            FFImageLoading.Forms.Touch.CachedImageRenderer.Init();
            var dummy = new FFImageLoading.Forms.Touch.CachedImageRenderer();

            global::Xamarin.Forms.Forms.Init();
            LoadApplication(new App());

            return base.FinishedLaunching(app, options);
        }

or a static FFImageLoading.Forms.Touch.CachedImageRenderer property.

Makes sense, but just tried the workaround and still not working.

[daniel-luberda]

What did you try?

[molinch]

I confirm that it works fine with the "hack" 👍

[daniel-luberda]

        /// <summary>
        ///   Used for registration with dependency service
        /// </summary>
        public static new void Init()
        {
        }

as you see it hides iOS specific method. Maybe it's this? Notice new keyword. We could change it to InitRenderer() and see if it'll work. I didn't notice it earlier.

You got this working in release mode with (Arm7 + Arm64) with that workaround molinch?

[molinch]

@HIGHPlains Yes dunno why it doesn't work on your side :( Could you try removing app and cleaning/rebuilding?

@daniel-luberda I'm almost sure it isn't related to method hiding. Method hiding shouldn't do anything to the linker. It generates a different method signature, classes will still invoke the iOS Init(), not this one.

[daniel-luberda]

@molinch Yes, but who knows how does it works inside. Original iOS Init() method is commented as necessary for preventing linking.

rookie move on my part, my bad! Ya the workaround does the trick.

[daniel-luberda]

So I have two questions:

• Should we modify or abandon CachedRenderer.Init method?
• Should we update README.md instructions to put a dummy instance instead of using Init method?

BTW: @molinch Nice catch with bugzilla bug :)

[molinch]

I don't think we need to do anything regarding Init() since this issue is absolutely unrelated to it. But maybe can you explain what you mean here: "Original method is commented as necessary for preventing linking."?

For your second point please don't do that. I'm trying something else.

[molinch]

No need to change the Readme. This way it's easier for the users of the package.
I will recreate the Forms nuget.

Appreciate it guys!

[daniel-luberda]

But maybe can you explain what you mean here: "Original method is commented as necessary for preventing linking."?

I'm VERY sure that I read something in Xamarin docs about it. Don't remember details though. While making FFImageLoading renderer I was trying to find if it will collide with something if I'll do method hiding for this one.

[daniel-luberda]

On the other side, many controls use Init method, eg SyncFusion (SfDataGridRenderer.Init() method), so maybe I'm just oversensitive about it.

[molinch]

TBH I quickly googled and couldn't find anything about it, all examples use Init(). But if you find something I'm happy to change it.

[molinch]

@daniel-luberda @HIGHPlains https://www.nuget.org/packages/Xamarin.FFImageLoading.Forms/1.1.7.1
Could you try it?

[daniel-luberda]

I can't find it too now, but I'm sure I read something about it. I'll try to find it and post it here.

@daniel-luberda you good with Forms.Droid? Is there a way to get in touch with you? We are close to initial seed funding on a startup and am going to need dev's familiar with Forms soon.

actually same with you @molinch

New nuget works in my app !

[molinch]

👍 Love to fix Xamarin bugs

@HIGHPlains I would love such challenges therefore I'm much more into plain Xamarin iOS/Xamarin Android. I didn't tackled Forms much.

Hard to find a good Xam / Xam.Forms team nowadays.

Android isn't my best either, better with iOS @molinch

[daniel-luberda]

@molinch The best bugs IMO is still some magic happening with ImageSource and propertychanged :)

@HIGHPlains Yes sure, I'm playing with Forms since its beginning (and a lot with Xamarin.Android too, since Novell times). Just mail me. myName.mySurname (at) gmail.com

@daniel-luberda i feel like half of my day is fixing Forms bugs lol

[daniel-luberda]

@HIGHPlains Yes true, a lot of bugs but can live with that if you know them. Actually a lot has changed for good. First version were more like not tested builds :) There were even bugs like if you had a ListView and scrolled it, its items were magically and dynamically mixing while scrolling (5th element became 1st) :D I remember that well because I filled it as a bug then.

lol ya i filed a few ListView bugs too.. There "HasUnevenRows" has been pretty bad and they way the listview behaves after adding or removing models to the observablecollections is still weird. But the last stable and recent pre release is showing promise. Overall though im a fan of the framework.

[daniel-luberda]

@HIGHPlains @molinch The good thing is it's progress. Xamarin.Forms is a great framework - but as you see, it cannot live without native Xamarin.iOS, Xamarin.Android renderers :) Ok. Thanks for catching / fixing bug.