Comments (8)
@molinch As this is anaisbetts/ModernHttpClient#184 not so bad, this one: anaisbetts/ModernHttpClient#185 is a real problem.
It would be nice to be able to choose alternative http clients in Initialize method. For now, I would also switch to mono HttpClientHandler. It will also make FFImageLoading independent of ModernHttpClient, which is another bright side (not everyone can use it).
Instead, when those bugs are fixed, I would add a short tutorial in README.md showing how to change http client to ModernHttpClient and make FFImageLoading requests faster.
from ffimageloading.
I agree with you #185 is really bad. #184 might be difficult to fix, it seems to be the Android network stack that has an issue. Mono has a different network stack, it opens its own sockets, so it is not affected.
Have you been able to reproduce these issues? And just switching the HttpClient in ImageService.Initialize
fixes both. Could you also give it a try?
Once I have your feedback I will switch to default HttpClient. It makes sense and people can still override it.
I'm all in for a blog post it's a great idea 👍 Also if you would like to improve the README then don't hesitate. I'm a bit worried about it's size, it could be splitted in more files IMO.
from ffimageloading.
Tested it, and it looks like it's solved on Android. Didn't test on iOS yet though.
from ffimageloading.
Actually, didn't notice any performance difference when using mono HttpClientHandler.
from ffimageloading.
Yeah me neither...
from ffimageloading.
Maybe the requests rate it's still to low to benefit from ModernHttpClient (eg. large image data responses vs high rate rest requests, etc).
from ffimageloading.
True, could be that our scenario is different from most use cases
from ffimageloading.
It looks like it's a win-win situation (less dependencies and no bugs) :)
from ffimageloading.
Related Issues (20)
- Check if Image Server side has changed from Cached version
- [Bug]In Xamarin.Forms (Android) throws System.ArgumentException in ImageService.SetTaskForTarget (FFImageLoading.Work.IImageLoaderTask currentTask).
- Support for image width/height query in the URL
- Some SVG images are displaying and some are not HOT 3
- CacheKeyFactory used in a CollectionView causes incorrect images to load.
- ReplaceStringMap Question
- Images from URL don't show at all on iOS in Xamarin Forms 5 app HOT 1
- For MAUI see here.... HOT 3
- Image Adjustments in Xamarin
- [ISSUE] [Android] GIF animation weird behavior
- App crashes after calling ImageService.SetTaskForTarget HOT 1
- Guid inside URL is changed
- .Net 6 support HOT 4
- Incomplete downloaded image is cached.
- Images disappear on Android after pressing the (hardware) Back button HOT 1
- .Net 8 support HOT 2
- RotateTransformation does not rotate images on iOS 17 HOT 1
- Image won't load in Maui Windows app
- Inquiry about Data Collection
- On windows image download fails randomly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ffimageloading.