Xamarin.Forms Sample about ffimageloading

[daniel-luberda]

I can do that :) First, I'll add placeholders handling support and than I'll send PR with some examples.

[molinch]

Great! Thanks @daniel-luberda 👍

[molinch]

It's already nice but it would be awesome if your sample used more features on both iOS and Android: local placeholders, maybe a list view to have more images (so we can test cancellation), ...

[daniel-luberda]

Ok, I'll add some more advanced example with lists, etc.

BTW: I noticed that error placeholder doesn't work with local images. However, loading placeholder works good with local images (they use the same CompiledResource type). Do we have a bug here? Or something else?

[molinch]

Weird it shouldn't be the case, error and loading placeholders rely on the same logic.
I'm really busy now but if you find anything I'm happy to have a look at it

[daniel-luberda]

#43

[molinch]

I consider this as done. If in the future you want to add functionalities (WebP decoding, other?) feel free to do that.

[daniel-luberda]

I'll be definitely adding some, when I'll have more free time.

It would be nice to implement Finish, Success, Error Actions.

Also Transformations in renderers would be useful. (That way we could have circle image which a lot people use). What do you think about moving samples/ImageLoading.Sample/Transformations/ files to regular library?

[molinch]

Currently the transformations samples are only done on Android. But if somebody makes a PR that contains the same transformations for both iOS and Android then yes: I would be happy to make a specific nuget like Xamarin.FFImageLoading.Transformations.
IMO if we don't have them cross platform then it makes no sense: we are trying to make a cross platform lib.

What's your point of view?

[daniel-luberda]

Yes, definitely cross-platform all the way. I have something: #47, tell me what do you think about it.

[molinch]

That's cool 👍 I will check the PR and let you know