Access to cache result about ffimageloading

[molinch]

It shouldn't be complicated to add this info. I will look into it.
Therefore I'm very interested with your iOS fading logic. There is a task about it in fact #16
Would you mind sharing your fading code for iOS? We might be able to integrate that in the lib.

[mgorbach]

Here's my fading code:

                if (imageLoadingWork != null)
                {
                    imageLoadingWork.Cancel();
                    imageLoadingWork = null;
                }

                Uri imageUrl = null;
                if (viewModel != null)
                {
                    var imageUrlViewModel = viewModel as IRemoteImage;
                    if (imageUrlViewModel != null)
                    {
                        imageUrl = imageUrlViewModel.ImageUrl;

                        if (imageUrl != null)
                        {
                            if (shownImageUrl == imageUrl)
                            {
                                // Nothing to do here, we are already showing the correct image
                                ContentImageView.Alpha = 1.0f;
                            }
                            else
                            {
                                // Clear the image and start loading the next one
                                ContentImageView.Image = null;
                                ContentImageView.Alpha = 0.0f;

                                var urlString = imageUrl.ToString();
                                imageLoadingWork = ImageService.LoadUrl(urlString)
                                    .Error(e => Console.WriteLine("Failed to load image: " + urlString + " error: " + e))
                                    .Success(() =>
                                    {
                                        shownImageUrl = imageUrl;
                                        UIView.AnimateNotify(
                                            AnimationDuration, 
                                            0.0f, 
                                            UIViewAnimationOptions.CurveEaseInOut,
                                            () =>
                                            {
                                                ContentImageView.Alpha = 1.0f;
                                            }, 
                                            null);
                                    })
                                    .Finish(work =>
                                    {
                                        // This is a special case that occurs when the image is being loaded from a disk cache. The work is not marked as either cancelled or completed.
                                        // In this case, we are going to stop to animation started by the success block and put the image onscreen without the fade
                                        bool loadedAlready = work.IsCancelled == false && work.Completed == false;
                                        if (loadedAlready && ContentImageView.Alpha == 1.0f)
                                        {
                                            ContentImageView.Layer.RemoveAllAnimations();
                                            ContentImageView.Alpha = 1.0f;
                                        }
                                    })
                                    .Into(ContentImageView);
                            }
                        }
                        else
                        {
                            ContentImageView.Alpha = 0.0f;
                            ContentImageView.Image = null;
                        }
                    }

[molinch]

@mgorbach this is implemented in git now. Success callback gives both the size and a LoadingResult enum. It allows you to know if it was loaded from Internet, Disk, ApplicationBundle, DiskCache, or MemoryCache.

Could you give it a try?

[mgorbach]

@molinch thanks for implementing this so quickly!

I can't quite try off git though, because I'm having trouble building the library. I'm trying to build the master branch on a Mac with the latest stable Xamarin Studio, and I'm getting a bunch of errors with missing references and WebP on iOS not being found, even though it seems to have restored the internal nuget packages as expected.

[molinch]

Ok don't worry, I will soon make a release on NuGet so this will be included

[molinch]

You can test this prerelease NuGet package: https://www.nuget.org/packages/Xamarin.FFImageLoading/1.1.6-alpha

If it works fine I'll make a release.

[mgorbach]

@molinch thanks, I just gave it a shot. I'm getting callbacks with a loading result, but it always seems to be "internet." I haven't changed any of the disk cache settings, so I'd expect the disk cache to be enabled by default. Might be it's a bug with the result implementation?

[mgorbach]

Also, the issue I was exploiting earlier still exists, and once the result implementation works it should probably be fixed. Specifically, when loading from the in-memory cache, the finish callback is called and both "completed" and "cancelled" are false. It seems like "completed" should be true in this case.

[molinch]

Weird I tested this and got data from Internet, DiskCache and MemoryCache :(
I will give it another try

[molinch]

And yes you are right it should have completed true when loading from Memory.

[molinch]

@mgorbach I retested all scenarios on both iOS and Android and it works fine: Disk, DiskCache, Internet, Memory... It's always giving the correct result.

There was just one issue, affecting iOS DiskCache only, but everything else was working fine.
Now this is fixed in git too and I will make a Nuget release soon.

Could you make a separate issue regarding the callbacks?

[molinch]

I pushed a new Alpha nuget https://www.nuget.org/packages/Xamarin.FFImageLoading/1.1.6-alpha1 which contains the last fix (plus other things)
I will make a release soon