RecyclerView problems about ffimageloading

[molinch]

Mmh very weird. Do you have anything special in console output?

[c1rus]

No :(

Not related with this issue, but i think that method GetStreamAsync should have a null check:

if (string.IsNullOrEmpty(path)) return null;

[molinch]

Updated sample from c1rus is here https://github.com/c1rus/ImageLoading.Sample

[molinch]

I'm almost 99% sure it's not a FFImageLoading bug.
I debugged and when cells are empty they didn't went into OnBindViewHolder... So something else looks wrong to me

[molinch]

When using standard ImageView instead of our ImageViewAsync I don't seem to have this issue. Even though that's quite strange, I will make additional tests.

[c1rus]

hmm, we are not only ones with that issue :)

http://stackoverflow.com/questions/29564824/recyclerview-disappearing-images

[molinch]

Yeah it's really weird... Basically RecyclerView seems to sometimes detach images so it calls ImageView.OnDetachedFromWindow(), and in our case we clear the drawable, but sometimes it won't go again in OnBindViewHolder()

[molinch]

Fixed by f806962?w=1

A new NuGet is also out there. It contains minor other improvements.

[molinch]

One remark though: it could be nice to have your updated sample in this project.

[c1rus]

thx, i will create PR later.

blank cells are solved, but this issue is still there.

[c1rus]

and one more thing :) can we get rid of flickering?

ffimageloading -> http://screencast.com/t/QOrtHbfjn

ImageService.LoadUrl("http://files.usvit.alejtech.eu/peto/6480947_xl.jpg")
   .Retry(3, 200)
   .DownSample(100, 100)
   .LoadingPlaceholder(Config.LoadingPlaceholderPath, FFImageLoading.Work.ImageSource.ApplicationBundle)
   .ErrorPlaceholder(Config.ErrorPlaceholderPath, FFImageLoading.Work.ImageSource.ApplicationBundle)
   .Into(vh.Image);

picasso -> http://screencast.com/t/i7OkWvQpksOH

var uri = Android.Net.Uri.Parse("http://files.usvit.alejtech.eu/peto/6480947_xl.jpg");
Squareup.Picasso.Picasso.With(context).Load(uri).Fit().Placeholder(Resource.Drawable.placeholder).Into(vh.Image);

[molinch]

Issue with image is weird but I should be able to find what happens.

Regarding flickering can you tell me your simulator settings? I don't experience it on my side, even with a low hardware device.

[c1rus]

Genymotion - Google Nexus 5 - 5.1.0 - API 22 - predefined settings

slow pc or am i scrolling fast? :)

[molinch]

Same configuration but still not that issue.
Anyway I refactored a bit some code so now when loading from memory cache it skips many things (and should be of course faster).
I won't make a NuGet for this unless heavily tested. Could you give me some feedback?
It is in this commit 2247205?w=1

[c1rus]

awesome, no flickering now :)

but i think something has broken, try run the sample and you will see.

http://screencast.com/t/ERMzONpgg5

[molinch]

Hi @c1rus this should be fixed now. Related commit is a85f090?w=1

[c1rus]

yes, it is fixed, thank you.

i have noticed that the sample is crashing, when url (path) is null or empty.
i can always manually check, but i want to show the placeholder, so maybe the library should handle it. What do you think?

Caused by: md52ce486a14f4bcd95899665e9d932190b.JavaProxyThrowable: System.Exception: Image loading key can not be null, empty or a whitespace

[molinch]

I'm very busy now but if you make a PR I would be happy to integrate it

[c1rus]

PR created, i'm just not sure if it should be considered as error.

Maybe there should be 3 kinds of placeholders :)

EmptyPlaceholder
LoadingPlaceholder
ErrorPlaceholder

or when the path is empty, show LoadingPlaceholder.