Comments (19)
Mmh very weird. Do you have anything special in console output?
from ffimageloading.
No :(
Not related with this issue, but i think that method GetStreamAsync should have a null check:
if (string.IsNullOrEmpty(path)) return null;
from ffimageloading.
Updated sample from c1rus is here https://github.com/c1rus/ImageLoading.Sample
from ffimageloading.
I'm almost 99% sure it's not a FFImageLoading bug.
I debugged and when cells are empty they didn't went into OnBindViewHolder... So something else looks wrong to me
from ffimageloading.
When using standard ImageView instead of our ImageViewAsync I don't seem to have this issue. Even though that's quite strange, I will make additional tests.
from ffimageloading.
hmm, we are not only ones with that issue :)
http://stackoverflow.com/questions/29564824/recyclerview-disappearing-images
from ffimageloading.
Yeah it's really weird... Basically RecyclerView seems to sometimes detach images so it calls ImageView.OnDetachedFromWindow(), and in our case we clear the drawable, but sometimes it won't go again in OnBindViewHolder()
from ffimageloading.
Fixed by f806962?w=1
A new NuGet is also out there. It contains minor other improvements.
from ffimageloading.
One remark though: it could be nice to have your updated sample in this project.
from ffimageloading.
thx, i will create PR later.
blank cells are solved, but this issue is still there.
from ffimageloading.
and one more thing :) can we get rid of flickering?
ffimageloading -> http://screencast.com/t/QOrtHbfjn
ImageService.LoadUrl("http://files.usvit.alejtech.eu/peto/6480947_xl.jpg")
.Retry(3, 200)
.DownSample(100, 100)
.LoadingPlaceholder(Config.LoadingPlaceholderPath, FFImageLoading.Work.ImageSource.ApplicationBundle)
.ErrorPlaceholder(Config.ErrorPlaceholderPath, FFImageLoading.Work.ImageSource.ApplicationBundle)
.Into(vh.Image);
picasso -> http://screencast.com/t/i7OkWvQpksOH
var uri = Android.Net.Uri.Parse("http://files.usvit.alejtech.eu/peto/6480947_xl.jpg");
Squareup.Picasso.Picasso.With(context).Load(uri).Fit().Placeholder(Resource.Drawable.placeholder).Into(vh.Image);
from ffimageloading.
Issue with image is weird but I should be able to find what happens.
Regarding flickering can you tell me your simulator settings? I don't experience it on my side, even with a low hardware device.
from ffimageloading.
Genymotion - Google Nexus 5 - 5.1.0 - API 22 - predefined settings
slow pc or am i scrolling fast? :)
from ffimageloading.
Same configuration but still not that issue.
Anyway I refactored a bit some code so now when loading from memory cache it skips many things (and should be of course faster).
I won't make a NuGet for this unless heavily tested. Could you give me some feedback?
It is in this commit 2247205?w=1
from ffimageloading.
awesome, no flickering now :)
but i think something has broken, try run the sample and you will see.
http://screencast.com/t/ERMzONpgg5
from ffimageloading.
Hi @c1rus this should be fixed now. Related commit is a85f090?w=1
from ffimageloading.
yes, it is fixed, thank you.
i have noticed that the sample is crashing, when url (path) is null or empty.
i can always manually check, but i want to show the placeholder, so maybe the library should handle it. What do you think?
Caused by: md52ce486a14f4bcd95899665e9d932190b.JavaProxyThrowable: System.Exception: Image loading key can not be null, empty or a whitespace
from ffimageloading.
I'm very busy now but if you make a PR I would be happy to integrate it
from ffimageloading.
PR created, i'm just not sure if it should be considered as error.
Maybe there should be 3 kinds of placeholders :)
EmptyPlaceholder
LoadingPlaceholder
ErrorPlaceholder
or when the path is empty, show LoadingPlaceholder.
from ffimageloading.
Related Issues (20)
- Check if Image Server side has changed from Cached version
- [Bug]In Xamarin.Forms (Android) throws System.ArgumentException in ImageService.SetTaskForTarget (FFImageLoading.Work.IImageLoaderTask currentTask).
- Support for image width/height query in the URL
- Some SVG images are displaying and some are not HOT 3
- CacheKeyFactory used in a CollectionView causes incorrect images to load.
- ReplaceStringMap Question
- Images from URL don't show at all on iOS in Xamarin Forms 5 app HOT 1
- For MAUI see here.... HOT 3
- Image Adjustments in Xamarin
- [ISSUE] [Android] GIF animation weird behavior
- App crashes after calling ImageService.SetTaskForTarget HOT 1
- Guid inside URL is changed
- .Net 6 support HOT 4
- Incomplete downloaded image is cached.
- Images disappear on Android after pressing the (hardware) Back button HOT 1
- .Net 8 support HOT 2
- RotateTransformation does not rotate images on iOS 17 HOT 1
- Image won't load in Maui Windows app
- Inquiry about Data Collection
- On windows image download fails randomly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ffimageloading.