Implement a Fit method about ffimageloading

[daniel-luberda]

It is working in Xamarin.Forms (CachedImage) and Windows (FFImage) - DownsampleToViewSize property.

[molinch]

Very cool !
It'll be very useful & powerful for users 😉

2015-12-06 19:05 GMT+01:00 Daniel Luberda [email protected]:

It is working in Xamarin.Forms (DownsampleToViewSize property)

—
Reply to this email directly or view it on GitHub
#14 (comment)
.

[xleon]

What about Android? is it implemented somehow? I tried ScaleToFit = true, but this is adjusting the height creating an square image. The width does not get adjusted

[daniel-luberda]

It isn't implemented on iOS and Android. @molinch suggested possible implementations but it isn't done yet.

[molinch]

Even though it's easy to provide the DownSample width or height.
So it's not a "blocker" not having Fit()

[daniel-luberda]

To summarize:

Platform	Xamarin Forms	Windows	Xamarin iOS	Xamarin Android
Manual Downsampling (fixed width/height values)	supported	supported	supported	supported
Auto Downsampling (image view size)	supported	supported	not supported	not supported

[xleon]

Well, yesterday I was trying to adjust in Android to the view container, using a fixed DownSample and it didn´t work. Maybe because I was also using rounded corners. I got always a square

[daniel-luberda]

Yes it's because of that. RoundedTransformations has additional constructor overrides to set width/height proportions: public RoundedTransformation(double radius, double cropWidthRatio, double cropHeightRatio). Just use them and you can control that.

Actually it did work but default RoundedTransformation constructor forces image to be a square:

public RoundedTransformation(double radius) : this(radius, 1d, 1d)

.Transform(new List<ITransformation> {
        new RoundedTransformation(7, 200, 120))
    }
.DownSample(200, 0)

or

.Transform(new List<ITransformation> {
        new RoundedTransformation(7, 200, 120))
    }
.DownSample(0, 120)

DownSample always maintain original image aspect ratio. If you do .DownSample(200, 120) one of parameters is ignored.

[xleon]

I got it working with

.Transform(new CornersTransformation(5, CornerTransformType.AllRounded, 200, 120))
.DownSample(200, 120)

But your example also works. Thanks!
BTW. This library is really cool. I´m using it in Mvvmcross and it´s working like a champ

[antferr]

How do it in XAML? Thanks