Coder Social home page Coder Social logo

HTTP notifier headers about helm-charts HOT 3 CLOSED

lowess avatar lowess commented on August 30, 2024
HTTP notifier headers

from helm-charts.

Comments (3)

Lowess avatar Lowess commented on August 30, 2024

Hi @invernizzie , Thanks for your interest for this repository.

Can you please provide an example of Burrow configuration with the Opsgenie integration (blank out your api key) so that I have an idea of the content of the notifier.<my-notifier>.headers section ?

It looks like Burrow handles well configuration overrides using environment variables as per linkedin/Burrow#486.

To implement the change I would recommend adding the headers section bellow https://github.com/Lowess/helm-charts/blob/master/charts/burrow/templates/burrow-configmap.yaml#L56 to handle non-sensitive headers.

For sensitive data leverage environment variables and Viper.

Regarding the LICENSE. All charts from this repo are under Apache2 license

Feel free to submit a PR I will be happy to help you review it and get it released.

from helm-charts.

invernizzie avatar invernizzie commented on August 30, 2024

Thanks @Lowess, I will definitely add the headers field to the notifier section of the configmap.

The headers for Opsgenie would look like this:

[notifier.opsgenie]
  [notifier.opsgenie.headers]
  Authorization="GenieKey #redacted#"
  Accept="application/json"

I'm not sure if I'd be able to override a single header with and env var given that burrow loads the headers section as a map, but I'll try it out. Otherwise I'll use an env var for the whole section.

from helm-charts.

Lowess avatar Lowess commented on August 30, 2024

You're right there is a good chance that you need to pass down all the headers as env var except if Viper does some merging logic when the two same keys are defined.

from helm-charts.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.