Failing compilation about dezoomify-rs

[technodrome]

Amazing work, first class suport :)
A big thank you for such attitude!

[lovasoa]

Hello,
I cannot reproduce this issue. Did you make any change to the code ?
The code is compiled with rust 1.42.0 on every commit on macos, windows, and linux, and the compilation works:
https://github.com/lovasoa/dezoomify-rs/runs/525952748?check_suite_focus=true

[lovasoa]

Can you provide a copy of the exact sequence of commands you use to install rust, clone the code, and compile it ?

[lovasoa]

Hmm... I think I guessed your mistake ! Your error message mentions progress.finish_with_message(&final_msg); being on line 263, whereas in the real code, it is on line 262. This means you added a line above in the code.

Given what you mention, my guess is that you added something like success = true; on line 254.

A statement that ends with a ; returns () in rust, meaning that your code is trying to put () into final_msg, which should be a string.

Next time, please provide the code you are trying to compile when reporting a compilation error 😉

And, about your original idea: it sounds like a good idea to me ! Do you want to make a PR ?

[technodrome]

Thank you for your hint and sorry about a bit of confusion - I've literally just started with Rust :)

I do think having return value reflect the actual result of the download operation opens many possibilities. I'd love to implement this but I am just starting with Rust and it would take quite long. If I manage to implement this, I will be sure to open a PR.

[lovasoa]

Here is the link to the part of the rust guide about if : https://doc.rust-lang.org/reference/expressions/if-expr.html
What is important and differs from most languages is that if blocks are expressions :

let result = if condition { "hello" } else { x = 1; } 

is not valid, because the if branch has the type &str and the else branch has the type ()

Do not hesitate to submit your PR now even if it's not ready (you can annotate it as Work In Progress), so that we can discuss it.

[lovasoa]

I made the change: starting with dezoomify-rs v1.8.4, dezoomify-rs will use a non-zero exit code when only some tiles could be downloaded.

[lovasoa]

Thank you for using the tool and reporting bugs !