Coder Social home page Coder Social logo

Comments (5)

lopsided98 avatar lopsided98 commented on August 20, 2024 1

Yeah, its this: https://github.blog/changelog/2023-01-30-git-archive-checksums-may-change/, although I don't know why its still happening even though they apparently reverted it (maybe caching).

It is really my fault though, as you are supposed to use fetchFromGitHub to avoid this exact problem, but it was a bit more difficult to properly generate the code for it with superflore so I never implemented it.

from nix-ros-overlay.

lopsided98 avatar lopsided98 commented on August 20, 2024 1

The entry point is here: https://github.com/lopsided98/superflore/blob/nixos-support/superflore/generators/nix/run.py

from nix-ros-overlay.

lopsided98 avatar lopsided98 commented on August 20, 2024

I'm going to leave things as they are for now, since the change is being reverted. When I get a chance I'll try to implement fetchFromGitHub, but no guarantees on when that will happen.

from nix-ros-overlay.

jeff-hykin avatar jeff-hykin commented on August 20, 2024

When I get a chance I'll try to implement fetchFromGitHub, but no guarantees on when that will happen.

No worries, I might be able to. Although I'm not sure how the current nix files are being generated. I see the superflore-gen-nix but I have no idea where the source code from that command is coming from since the superflore repo doesn't mention anything like fetchurl or superflore-gen-nix.

https://github.blog/changelog/2023-01-30-git-archive-checksums-may-change/

Wow I'm honeslty suprised more of the nixpkgs stuff I use isnt breaking. I always grab straight from tar files.

I've updated hashes for ~600 files using a script, but that was before I knew tar files were the problem here (I did get the nix-shell command from the readme working though). I can probably just use the same script to switch them all to fetchFromGithub. If you're generating the files though, the script I made is a pretty hacky solution so I doubt it would work long term.

from nix-ros-overlay.

jeff-hykin avatar jeff-hykin commented on August 20, 2024

Thanks! I went ahead and made a fork that adds fetchFromGithub when its possible to, but otherwise keeps the old functionality. It does depend on nix-prefetch, which is the only reliably way I know to get the sha256 for fetchFromGithub.

I did some dryrun's and everything seems to be working (at least as much as it was before); I confirmed the outputs include fetchFromGithub and work. The generator is skipping a lot of packages though, so I wonder if I need to force a reevaluation of all packages.

I'm not sure about the AUTH token stuff, it seems to me like the dry run is good enough for me to generate nix-ros-overlay.

from nix-ros-overlay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.