Default sort order may impact performance on some queries about loopback-connector-mongodb

[simonecogno]

+1 I have loose 4 hours to find what was the performance problem of my query

[HugoPoi]

UP This issue is still relevant for 1.18.x and 3.x.

See
https://github.com/strongloop/loopback-connector-mongodb/blob/c0c75f915ea54079e66c819e28036b7c7bf6f7d6/lib/mongodb.js#L729-L734
And
https://github.com/strongloop/loopback-connector-mongodb/blob/0041f217019c84983ba3eec39c0ac993807289fc/lib/mongodb.js#L849-L854

@kjdelisle Can we re-open and merge #177 ?

[HugoPoi]

@dhmlau @jannyHou I open PR #437 based on your suggestion and inspired by #177

[raymondfeng]

Maybe we can make it controllable via a model/method level configuration property.

[mazesoul]

+1

[Ijmir]

+1

[thaiat]

+1

[SynerG]

+1 Please, fix this. Even if you create a specific index for your query, MongoDb cannot use the index because Loopback requests to order by _id, and the field is not included in the index. MongoDB docs explain it: https://docs.mongodb.org/manual/core/index-intersection/#index-intersection-and-sort

[sebastianhaas]

+1

[0101adm]

+1

[bidos]

+1

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sebastianhaas]

This is still relevant to me!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sebastianhaas]

Don't!

[HugoPoi]

I loose one day because of this default sort operation on "_id". THE DEFAULT BEHAVIOR FOR MONGODB MUST BE NO SORT when no sort operation is specify !
Please merge #177 !

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sebastianhaas]

Don't

[dhmlau]

@strongloop/lb-next-dev , seems like this is a popular feature request, and a related PR ready (#177). Want to initiate the discussion on how we're going to tackle it?

[jannyHou]

I think we can continue the discussion based on @raymondfeng 's suggestion in #177

Two thoughts around the proposal:
    - Should we provide a configuration option at app/model level to control if order by id should be enforced?
    - We should support the same option for all connectors.

A global flag(app/model level) sounds good to me, considering one app can have multiple datasources/models, we can start with enabling the model level config.
And we can change this line in #177 to read the flag from modelDefinition.settings

Anyone interested to create a PR to continue the work in #177 ? I can help review and land it.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dhmlau]

In evaluation whether we can work on it for July milestone

[jannyHou]

Should be fixed by #437, i am closing this issue.
Feel free to reopen it if you still have the problem.