Coder Social home page Coder Social logo

Comments (2)

jfsiii avatar jfsiii commented on June 1, 2024

My preference is that getDominantColor's response format change to an array [num, num, num] to match createPalette

This make CSS strings as easy as:

var dominant = getDominantColor(image); // [1, 11, 111]
var CSS = 'rgb(' + dominant + ')';      // rgb(1,111,111)

{r: num, g: num, b: num} may be more explicit but it doesn't have the toString benefits shown above and you'll still have to pick out individual elements whether using an array or an object.

For example:

var obj = {r: 1, g: 11, b: 111}
if (obj.r) { /* do something */ }

var arr = [1, 11, 111];
if (arr[0]) { /* do something */}

var r = arr[0], g = arr[1], b = arr[2];
if (r) { /* do something */}

from color-thief.

lokesh avatar lokesh commented on June 1, 2024

Updated with your pull request.

from color-thief.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.