Coder Social home page Coder Social logo

Remove indirect dependencies about plaso HOT 11 OPEN

thinrope avatar thinrope commented on August 21, 2024
Remove indirect dependencies

from plaso.

Comments (11)

joachimmetz avatar joachimmetz commented on August 21, 2024

cryptography should be no longer there, idna and cffi we would need to check.

from plaso.

joachimmetz avatar joachimmetz commented on August 21, 2024

looks like idna was a requirement of cryptography and requests, cryptography is no longer used, but let me check requests

from plaso.

joachimmetz avatar joachimmetz commented on August 21, 2024

Looks like idna still is a dependency of requests https://github.com/psf/requests/blob/main/setup.cfg#L6 . I would need to look why it was explicitly added instead of it being an implicit dependency. I recommend we keep that one for now.

from plaso.

joachimmetz avatar joachimmetz commented on August 21, 2024

And cffi is a dependency of xattr https://github.com/xattr/xattr/blob/main/pyproject.toml#L15

from plaso.

joachimmetz avatar joachimmetz commented on August 21, 2024

I would need to assess first, the reason for these indirect dependencies were added. Likely due to one of the packaging/environments failing to include them.

from plaso.

joachimmetz avatar joachimmetz commented on August 21, 2024

Looks like cffi was added for cryptography but this predates the inclusion of xattr 221a298

from plaso.

joachimmetz avatar joachimmetz commented on August 21, 2024

Idna was explicitly added for requests 8871cd9

from plaso.

thinrope avatar thinrope commented on August 21, 2024

I'll work on this a bit more, but here are my thoughts:

  • no indirect deps should be present in dependencies.ini and requirements.txt, they may be in some of the CICD files
  • given that I removed those 3 and tests passed, we need better tests :-) May be something that uses IDNA url for example

from plaso.

joachimmetz avatar joachimmetz commented on August 21, 2024

no indirect deps should be present

Unfortunately the "should" here is one of those theory versus reality arguments. They were added because they were needed.

  • Given they are used indirectly anyway, they not abundant, we can take the time to take a closer look why they were originally added
  • Many things have changed since they were added it could be that they are no longer needed.

we need better tests :-)

tests can always be improved

from plaso.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.