Comments (11)
cryptography should be no longer there, idna and cffi we would need to check.
from plaso.
looks like idna was a requirement of cryptography and requests, cryptography is no longer used, but let me check requests
from plaso.
Looks like idna still is a dependency of requests https://github.com/psf/requests/blob/main/setup.cfg#L6 . I would need to look why it was explicitly added instead of it being an implicit dependency. I recommend we keep that one for now.
from plaso.
And cffi is a dependency of xattr https://github.com/xattr/xattr/blob/main/pyproject.toml#L15
from plaso.
I would need to assess first, the reason for these indirect dependencies were added. Likely due to one of the packaging/environments failing to include them.
from plaso.
Looks like cffi was added for cryptography but this predates the inclusion of xattr 221a298
from plaso.
Idna was explicitly added for requests 8871cd9
from plaso.
I'll work on this a bit more, but here are my thoughts:
- no indirect deps should be present in
dependencies.ini
andrequirements.txt
, they may be in some of the CICD files - given that I removed those 3 and tests passed, we need better tests :-) May be something that uses IDNA url for example
from plaso.
no indirect deps should be present
Unfortunately the "should" here is one of those theory versus reality arguments. They were added because they were needed.
- Given they are used indirectly anyway, they not abundant, we can take the time to take a closer look why they were originally added
- Many things have changed since they were added it could be that they are no longer needed.
we need better tests :-)
tests can always be improved
from plaso.
Related Issues (20)
- Unable to install Plaso via (unsupported installation method) pip HOT 1
- Update of Ubuntu 22.04 with recent Plaso release HOT 8
- Python 3.12 DeprecationWarning fork()
- Add more structure to test_data directory
- Add support for signed XML plist files
- Enhance Mac OS background items plist parser plugin
- Create parser and parser plugins for Apple Biome files (aka: SEBG files) HOT 10
- How do I select parsers? HOT 20
- How do I use the winiis text parser plugin? HOT 1
- Windows Event Log message strings support enhancements
- Release plaso 20240308
- Change winlnk parser to not generate distributed_link_tracking event data for duplicate identifier
- Add TeamViewer log parser HOT 1
- Image export: change default behavior to not export file system metadata files
- Windows shim databases produce spurious UTMP events HOT 1
- Replace Redis with Valkey
- Remove obsolete functionality
- acstore pre-release causing AttributeError: 'SQLiteStorageFile' object has no attribute '_CONTAINER_SCHEMA_TO_SQLITE_TYPE_MAPPINGS' HOT 9
- Unable to use parser in event filter after version 20230717? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plaso.