Comments (4)
Yeah, bad choice of word, "sacred", but I remembered about reading in some thread (or if it was in code?) that changes to it wasn't advised :)
Well, I have a couple of days now when the rest of the team has vacation that I could spend looking into it.
You are referring to "the old one", has there been a different dispatcher implementation?
I could look through the git history if that is the case.
I'll start working on a DeterministicUsersDispatcher
then, instead of patching the current algorithm. Basically, not using weights, only fixed numbers and also being able to "tag" user types to a set of workers.
from locust.
The old one was completely different (locust 1.x), done on the workers not on the master (which had other limitations, because each worker had exactly the same distribution), so it is not much to look at :)
Cool! The current implementation is still pretty deterministic (so you should probably name the new one something else), it is just that it has time ticks as opposed to the old one, which had no time ticks (if I remember correctly). Probably dont want to change that in your PR, as that would be a major change :)
Perhaps it could be named CountBasedUserDispatcher? (as opposed to the current one which is "weight based")
To be able to use it fully there would need to be some ui/command line changes too (because you would specify counts for each user type instead of just a total user count), but if you build the dispatcher implementation I can help out with the other stuff.
from locust.
I have something working, but I want to run some extensive testing in our project before creating a PR here for it.
from locust.
The dispatcher code is not "sacred", but it was contributed by @mboutet and I dont know if he's still around? (so I'm hesitant to change it)
While the dispatcher implementation does seem to hold up for most use cases it is "less deterministic" than the old one and doesnt scale as well with high user, worker and user type counts.
What would be kind of cool is offering a completely separate algorithm: Not based on specifying weights and a total user count but on per-User type-numbers (like most other load test tools do it). This might involve a little more work than what you had imagined, but that would make me like the proposed change more :)
from locust.
Related Issues (20)
- Locust spams error if Host is invalid HOT 1
- [LocustLineChart] Implement an option/configuration for users to customize the color of the LocustLineChart. HOT 7
- CVE-2023-6246 vulnerability with latest docker image. HOT 2
- Add support with logging.config.dictConfig HOT 2
- Modern UI - User class picker - add option to enable/disable everything.
- Allow users to define custom metrics to track HOT 1
- Modern UI: ability to sort tables by column specific column HOT 1
- After launching the web interface and accessing I see CRITICAL/locust.web 404 Not Found in output HOT 4
- Modern UI: Add exception message column on the Exception Statistics HOT 1
- Modern UI: Average Response Time and 95th percentile have the same color HOT 2
- Same API call of the different URL string. HOT 1
- [Report][Modern-UI] HTML report is blank HOT 9
- Feature Request: Support for multiple real users to access the Locust UI simultaneously, each managing their own tests HOT 1
- Bug / Feature request: Time intensive `custom_messages` functions trigger heartbeat timeout HOT 4
- Blank page when accessing Locust Web UI via reverse proxy with subpath HOT 3
- SocketIOUser send method supports specific subscribe request HOT 1
- Statistics not visible while testing WebSockets using User module
- Python Crash during running distributed mode HOT 2
- Workers shutting down with getting no response from master after stopping or ending a load run HOT 3
- Need http2 requests support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from locust.