QA | Improve tests about curated-tv-and-film

[jnelson180]

I'll make a PR with some Jest tests.

[lmcjt37]

I have added the basic snapshot tests for the components I have separated out.

Further tests required for methods.

[CometS1]

I would like to make some tests for the methods. Do you know how to test to see how the state has changed?

[lmcjt37]

@CometS1 You should be able to do a shallow render of the component. Then expect the state to change after a method call, checking this before and after.

eg. You have a state of disabled for <Component/>

it(‘should change state’, () => {
  const wrapper = shallow(<Component />);
  
  expect(wrapper.state().disabled).toEqual(true);
  
  wrapper.instance().method(); // I believe this is right - you may need to spy on the method

  expect(wrapper.state().disabled).toEqual(false);
}); 

[CometS1]

I was making a test for the showFilters state to see whether the toggle would change its state, and managed to get it working on a previous version, but when I updated to the current version of the repository, it now says that it no longer can read the state. Here is my current code:

`it('testing for changed toggle state', () => {
const wrapper = shallow();

expect(wrapper.state().showFilters).toEqual(false);

wrapper.instance().toggleFilter();

expect(wrapper.state().showFilters).toEqual(true);
}); `

And I get the error "Cannot read property 'showFilters' of null". Do you know if any recent changes would have caused it?

[lmcjt37]

@CometS1 The project has come on quite a bit since Hacktoberfest.

I have broken the project into separate components and changed the testing strategy. These could have both had an impact of how your tests were originally running?

I can always help you work through the code if you commit a PR, I do have a slack workspace too which I can add you too if you want to talk around any other areas of the project.

[lmcjt37]

Closing as most cases are covered.