Comments (8)
@gitoleg could you double-check that this PR builds with BUILD_SHARED_LIBS=ON
please?
from clangir.
I'm going to revert that PR, circular dependencies are not acceptable.
shared libraries as well
That'd be great. Do you know how to do it? I have no clue! (cc: @lanza)
from clangir.
@ChuanqiXu9 had to revert your PR, more context above ^
from clangir.
Oh, got it. No problem at all. I'll try to look into that when I have time.
from clangir.
That'd be great. Do you know how to do it? I have no clue!
@bcardosolopes well, you need to add -DBUILD_SHARED_LIBS=ON
in your cmake args.
from clangir.
That'd be great. Do you know how to do it? I have no clue!
@bcardosolopes well, you need to add
-DBUILD_SHARED_LIBS=ON
in your cmake args.
My question was regarding how to enable that for github testing to pick up on it. If you know what needs to change I'm happy approving a PR
from clangir.
@bcardosolopes
got it)
well, it's been a while since I touched github actions (8 years, omg! :) ) but I can do it!. But we need to fix the build itself first.
Now the problem is that clangCIR
depends on MLIRCIRTransforms
, and MLIRCIRTransforms
depends on TargetLowering
that used CIRDataLayout
which is in clangCIR
.
I'm not sure that's good that CIR codegen
somehow depends on MLIRCIRTransforms
. Maybe we can place CIRPasses.cpp
somewhere else, I don't know.
So it's really a problem. And I don't know, if I'm the only who uses build with shared lib (though it's faster! :) ) But the longer we don't have such test build the more problems we will have in future.
from clangir.
well, it's been a while since I touched github actions (8 years, omg! :) ) but I can do it!.
Awesome!
Now the problem is that clangCIR depends on MLIRCIRTransforms , and MLIRCIRTransforms depends on TargetLowering that used CIRDataLayout which is in clangCIR .
@sitio-couto looks like target lowering introduced a cycle. Please make sure you prioritize solving this problem before you land more work, or at least soon enough. Cycles are not acceptable. Might be worth checking shared builds in your workflow as you add more of these abstractions.
So it's really a problem. And I don't know, if I'm the only who uses build with shared lib (though it's faster! :) ) But the longer we don't have such test build the more problems we will have in future.
This also affects how we use our compiler internally, so you are not alone.
from clangir.
Related Issues (20)
- Should use `getCalleeAttr` when lowering `CallOp`
- Should mark private visibility for extern symbols.
- Vector related arith missing `nsw` on addition HOT 2
- Revisit insertion point being restored by an InsertionGuard in `buildSwitchBody()` HOT 1
- [Umbrella] Switch stmt CIRGen issues
- Single-operand vector shuffling HOT 1
- [ThroughMLIR] cir-opt can not work when lowering ForOp to scf HOT 4
- Add a test for arrays of 3-component extended vectors
- Crash with try statement HOT 1
- [GSoC] Add OpenCL support to compile GPU kernels
- Reinstate #668 and #678 HOT 2
- Verify ZdlPv -> ZdlPvm in `test/CIR/CodeGen/dtors.cpp`
- Verify gep uses moving to i64
- Replace uses of `isa`/`dyn_cast`/`cast`/... member functions HOT 2
- Data layout modeling for CIR types
- Add support for `__atomic_thread_fence` HOT 3
- Add canonicalization passes for cir.complex.create
- Problem with emitting MLIR from CIR: `cir.func` gets `dsolocal` attribute HOT 4
- Non-constant memory order in atomic built-ins HOT 3
- Keep higher level abstraction for runtime memory orders on atomics
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clangir.