Coder Social home page Coder Social logo

Comments (2)

bcardosolopes avatar bcardosolopes commented on August 16, 2024 1

Should the type of RTTI pointers be cir.ptr<!s8i> instead of cir.ptr<!u8i>?

The idea when cir.ptr<!u8i> was first introduced was to basically mean cir.ptr<!void>, which we didn't have at the time. This is more about having a canonical representation for these "opaque" things that we store. Changing might sound like a reasonable approach, but it's possible whenever these values are needed they are being casted to the appropriated type, did you check that? I'm also against changing all of it to s8, ptrs not related to casted offsets should still be u8, and it's just super confusing to readers to make them s8.

llvm ir 12.0.1

This is old, not even using opaque pointers. As a general advice, I suggest you base up your investigations on top of clang-18 or trunk.

So, similar to LLVM IR, Should the insertion of global variables be centralized at the beginning of the module?

We should do a better job, for sure. LLVM codegen has a somewhat lazy approach for global variables, so it's not exactly like you are pointing out. Any improvements here should definitely account for a similar approach from the original LLVM codegen.

Thanks for pointing out (1) and (2), as you noticed, they are pre-requisites into implementing multiple inheritance.

from clangir.

Laity000 avatar Laity000 commented on August 16, 2024 1

Thank you for your response. Please review the discussion about the vtable type in this PR. #569

from clangir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.