Coder Social home page Coder Social logo

Comments (2)

mikefullerton avatar mikefullerton commented on June 25, 2024

Also, please let me know if my description of the problem is confusing or needs elaboration.

thanks

from yajl.

winterweird avatar winterweird commented on June 25, 2024

I was actually going to create a new issue here if I didn't see something similar. As an additional note, I'd like to add that the build fails just from having "yajl/yajl_common.h" in the relative path from the source file. That is not ideal. It's easily circumvented by adding a -I. option to the compile flags (GCC at least), but I really think it should work out of the box. As such, I'd actually recommend to modify the includes to use quotes instead of angle brackets. The only difference it makes is that the preprocessor looks for a "yajl/yajl_common.h" in the relative path first before going through everything else. This would also be more consistent with how yajl_tree.h is included in the example program.

Personally I don't consider the folder structure YAJL expects as a problem. In one of my normal projects, even this little peculiarity wouldn't be a problem, since I tend to put everything under include/ and have a compiler flag for searching that folder. There wouldn't be a problem putting YAJL-related headers in a folder named "yajl". The only reason I discovered this problem was from adapting another person's project and not wanting to refactor too much and/or wanting to be consistent. However, in the case that "yajl/yajl_common.h" is in the relative path to the source file, you wouldn't expect it to flat out error, so I'm in favor of the way of the double quotes.

Best regards! (Also, I'm not really expecting a comment on an issue from 2011 to have an impact, but I wanted to put this out there.)

from yajl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.