Coder Social home page Coder Social logo

Comments (7)

0crat avatar 0crat commented on August 21, 2024

@llorllale/z please, pay attention to this issue

from cactoos-matchers.

llorllale avatar llorllale commented on August 21, 2024

@dgroup what do you mean "extend"? You want to create a new class that extends hamcrest's AllOf?

from cactoos-matchers.

dgroup avatar dgroup commented on August 21, 2024

@llorllale, yes

/**
 * ...
 */
public final class AllOf<T> extends org.hamcrest.core.AllOf<T> {
    /**
     * ...
     */
    public AllOf(final Matcher<? super T> ... matchers) {
        super(new IterableOf<>(matchers));
    }
}

Also we can write the own implementation of Matcher, but i think it will be overengineering for this case.

from cactoos-matchers.

llorllale avatar llorllale commented on August 21, 2024

@dgroup I think it would be better to provide a PR for hamcrest.

from cactoos-matchers.

dgroup avatar dgroup commented on August 21, 2024

@llorllale , initially the issue raised because i through

  1. They already give this feature as Matchers.allOf(...) and available with hamcrest-all.
  2. They promoting the usage of matchers through static methods annotated as @org.hamcrest.Factory, thus it already implemented, no need to add it to the hamcrest-core
  3. There were no any releases since 2015 in maven central, so it will take months in order to receive such simple feature, however, i've checked today, and found that recently the've released the
    <dependency>
      <groupId>org.hamcrest</groupId>
      <artifactId>hamcrest</artifactId>
      <version>2.1</version>
    </dependency>
    https://mvnrepository.com/artifact/org.hamcrest/hamcrest/2.1
    Will try.

from cactoos-matchers.

0crat avatar 0crat commented on August 21, 2024

Job gh:llorllale/cactoos-matchers#73 is not assigned, can't get performer

from cactoos-matchers.

0crat avatar 0crat commented on August 21, 2024

This job is not in scope

from cactoos-matchers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.