Coder Social home page Coder Social logo

Comments (1)

white238 avatar white238 commented on June 6, 2024

I see two solutions:

  1. Have the user required to not provide a YAPF config file if you don't provide Python files to add code checks for (this seems less than robust).

  2. Check on each of these if blocks that you are actually providing source files to run checks for:

    if (YAPF_FOUND AND DEFINED arg_YAPF_CFG_FILE)
    set(_check_target_name ${arg_PREFIX}_yapf_check)
    blt_error_if_target_exists(${_check_target_name} ${_error_msg})
    set(_style_target_name ${arg_PREFIX}_yapf_style)
    blt_error_if_target_exists(${_style_target_name} ${_error_msg})
    blt_add_yapf_target( NAME ${_check_target_name}
    MODIFY_FILES FALSE
    CFG_FILE ${arg_YAPF_CFG_FILE}
    WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
    SRC_FILES ${_py_sources} )
    blt_add_yapf_target( NAME ${_style_target_name}
    MODIFY_FILES TRUE
    CFG_FILE ${arg_YAPF_CFG_FILE}
    WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
    SRC_FILES ${_py_sources} )
    endif()

I would lean towards the second option.

from blt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.