Coder Social home page Coder Social logo

Support Redis ACL and/or URL about livekit HOT 3 CLOSED

livekit avatar livekit commented on May 22, 2024
Support Redis ACL and/or URL

from livekit.

Comments (3)

Redmega avatar Redmega commented on May 22, 2024

redis-go does have a method of parsing full redis url schemas

opt, err := redis.ParseURL("rediss://<user>:<pass>@localhost:6379/<db>")
if err != nil {
    panic(err)
}

rdb := redis.NewClient(opt)

I'm not too familiar with Go but my first impression was to use REDIS_HOST for both HOST or URL:

opt := redis.ParseURL(config.Redis.Address)
//pseudocode
if(config.Redis.Password != "") {
  opt.Password = config.Redis.Password
}
// /pseudocode

rc := redis.NewClient(opt)

But that might be confusing. Might be better to accept REDIS_URL that gets parsed (as you mentioned in Slack), and then have a fallback to REDIS_HOST, REDIS_USERNAME, and REDIS_PASSWORD (and REDIS_DB? Not sure how this is used as I believe my org simply uses the default)

from livekit.

davidzhao avatar davidzhao commented on May 22, 2024

Added Redis ACL support in 54584d6 (v0.7.5). Will handle DB selection in the future.

from livekit.

davidzhao avatar davidzhao commented on May 22, 2024

this capability has been added.

from livekit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.